* [PATCH] ipv6: Silence privacy extensions initialization
@ 2011-01-17 17:59 Romain Francoise
2011-01-19 0:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Romain Francoise @ 2011-01-17 17:59 UTC (permalink / raw)
To: David S. Miller
Cc: Alexey Kuznetsov, Pekka Savola (ipv6), James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev
When a network namespace is created (via CLONE_NEWNET), the loopback
interface is automatically added to the new namespace, triggering a
printk in ipv6_add_dev() if CONFIG_IPV6_PRIVACY is set.
This is problematic for applications which use CLONE_NEWNET as
part of a sandbox, like Chromium's suid sandbox or recent versions of
vsftpd. On a busy machine, it can lead to thousands of useless
"lo: Disabled Privacy Extensions" messages appearing in dmesg.
It's easy enough to check the status of privacy extensions via the
use_tempaddr sysctl, so just removing the printk seems like the most
sensible solution.
Signed-off-by: Romain Francoise <romain@orebokech.com>
---
net/ipv6/addrconf.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 5b189c9..24a1cf1 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -420,9 +420,6 @@ static struct inet6_dev * ipv6_add_dev(struct net_device *dev)
dev->type == ARPHRD_TUNNEL6 ||
dev->type == ARPHRD_SIT ||
dev->type == ARPHRD_NONE) {
- printk(KERN_INFO
- "%s: Disabled Privacy Extensions\n",
- dev->name);
ndev->cnf.use_tempaddr = -1;
} else {
in6_dev_hold(ndev);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: Silence privacy extensions initialization
2011-01-17 17:59 [PATCH] ipv6: Silence privacy extensions initialization Romain Francoise
@ 2011-01-19 0:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-01-19 0:14 UTC (permalink / raw)
To: romain; +Cc: kuznet, pekkas, jmorris, yoshfuji, kaber, netdev
From: Romain Francoise <romain@orebokech.com>
Date: Mon, 17 Jan 2011 18:59:18 +0100
> When a network namespace is created (via CLONE_NEWNET), the loopback
> interface is automatically added to the new namespace, triggering a
> printk in ipv6_add_dev() if CONFIG_IPV6_PRIVACY is set.
>
> This is problematic for applications which use CLONE_NEWNET as
> part of a sandbox, like Chromium's suid sandbox or recent versions of
> vsftpd. On a busy machine, it can lead to thousands of useless
> "lo: Disabled Privacy Extensions" messages appearing in dmesg.
>
> It's easy enough to check the status of privacy extensions via the
> use_tempaddr sysctl, so just removing the printk seems like the most
> sensible solution.
>
> Signed-off-by: Romain Francoise <romain@orebokech.com>
Yes, this message always bugged me too, applied thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-19 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-17 17:59 [PATCH] ipv6: Silence privacy extensions initialization Romain Francoise
2011-01-19 0:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).