From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jesse@nicira.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net offloading: Do not mask out NETIF_F_HW_VLAN_TX for vlan.
Date: Tue, 18 Jan 2011 16:15:34 -0800 (PST) [thread overview]
Message-ID: <20110118.161534.232762549.davem@davemloft.net> (raw)
In-Reply-To: <1295333714.3362.561.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 18 Jan 2011 07:55:14 +0100
> Le lundi 17 janvier 2011 à 22:46 -0800, Jesse Gross a écrit :
>> In netif_skb_features() we return only the features that are valid for vlans
>> if we have a vlan packet. However, we should not mask out NETIF_F_HW_VLAN_TX
>> since it enables transmission of vlan tags and is obviously valid.
>>
>> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
>> Signed-off-by: Jesse Gross <jesse@nicira.com>
>
> Thanks Jesse
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2011-01-19 0:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 6:46 [PATCH] net offloading: Do not mask out NETIF_F_HW_VLAN_TX for vlan Jesse Gross
2011-01-18 6:55 ` Eric Dumazet
2011-01-18 7:12 ` Jesse Gross
2011-01-18 17:21 ` Michael Chan
2011-01-19 0:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118.161534.232762549.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).