From: David Miller <davem@davemloft.net>
To: dm@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] cxgb4: fix reported state of interfaces without link
Date: Thu, 20 Jan 2011 17:00:50 -0800 (PST) [thread overview]
Message-ID: <20110120.170050.215541105.davem@davemloft.net> (raw)
In-Reply-To: <1295486945-22015-1-git-send-email-dm@chelsio.com>
From: Dimitris Michailidis <dm@chelsio.com>
Date: Wed, 19 Jan 2011 17:29:05 -0800
> Currently tools like ip and ifconfig report incorrect state for cxgb4
> interfaces that are up but do not have link and do so until first link
> establishment. This is because the initial netif_carrier_off call is
> before register_netdev and it needs to be after to be fully effective.
> Fix this by moving netif_carrier_off into .ndo_open.
>
> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
Applied.
prev parent reply other threads:[~2011-01-21 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 1:29 [PATCH net-2.6] cxgb4: fix reported state of interfaces without link Dimitris Michailidis
2011-01-21 1:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120.170050.215541105.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).