netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.r.fastabend@intel.com>
To: kaber@trash.net
Cc: john.r.fastabend@intel.com, netfilter-devel@vger.kernel.org,
	netdev@vger.kernel.org, pablo@netfilter.org
Subject: [PATCH] netfilter: undefined reference to 'nf_conntrack_tstamp_*'
Date: Thu, 20 Jan 2011 11:16:12 -0800	[thread overview]
Message-ID: <20110120191612.24205.73463.stgit@jf-dev1-dcblab> (raw)

net/built-in.o: In function `nf_conntrack_init_net':
net/netfilter/nf_conntrack_core.c:1521:
	undefined reference to `nf_conntrack_tstamp_init'
net/netfilter/nf_conntrack_core.c:1531:
	undefined reference to `nf_conntrack_tstamp_fini'

Add 'selects' notation to Kconfig to include NF_CONNTRACK_TIMESTAMP
this resolves all the config files I tested.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
CC: Pablo Neira Ayuso <pablo@netfilter.org>
---

 net/netfilter/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index faf7412..2079911 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -27,6 +27,7 @@ config NETFILTER_NETLINK_LOG
 config NF_CONNTRACK
 	tristate "Netfilter connection tracking support"
 	default m if NETFILTER_ADVANCED=n
+	select NF_CONNTRACK_TIMESTAMP
 	help
 	  Connection tracking keeps a record of what packets have passed
 	  through your machine, in order to figure out how they are related
@@ -87,7 +88,7 @@ config NF_CONNTRACK_EVENTS
 
 config NF_CONNTRACK_TIMESTAMP
 	bool  'Connection tracking timestamping'
-	depends on NETFILTER_ADVANCED
+	default m if NETFILTER_ADVANCED
 	help
 	  This option enables support for connection tracking timestamping.
 	  This allows you to store the flow start-time and to obtain


             reply	other threads:[~2011-01-20 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 19:16 John Fastabend [this message]
2011-01-20 19:52 ` [PATCH] netfilter: undefined reference to 'nf_conntrack_tstamp_*' Patrick McHardy
2011-01-20 20:05   ` John Fastabend
2011-01-20 20:10     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110120191612.24205.73463.stgit@jf-dev1-dcblab \
    --to=john.r.fastabend@intel.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).