From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, kaber@trash.net, hawk@diku.dk,
jarkao2@gmail.com, hadi@cyberus.ca
Subject: Re: [PATCH net-next-2.6] net_sched: TCQ_F_CAN_BYPASS generalization
Date: Fri, 21 Jan 2011 16:27:33 -0800 (PST) [thread overview]
Message-ID: <20110121.162733.123411406.davem@davemloft.net> (raw)
In-Reply-To: <1295607881.2601.31.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 Jan 2011 12:04:41 +0100
> Now qdisc stab is handled before TCQ_F_CAN_BYPASS test in
> __dev_xmit_skb(), we can generalize TCQ_F_CAN_BYPASS to other qdiscs
> than pfifo_fast : pfifo, bfifo, pfifo_head_drop and sfq
>
> SFQ is special because it can have external classifiers, and in these
> cases, we cannot bypass queue discipline (packet could be dropped by
> classifier) without admin asking it, or further changes.
>
> Its worth doing this, especially for SFQ, avoiding dirtying memory in
> case no packets are already waiting in queue.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
> I am not sure RED can use bypass too, feel free to comment on this ;)
The only thing that RED would seem to care about would be the
queue size average calculation.
next prev parent reply other threads:[~2011-01-22 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 9:50 [PATCH net-next-2.6] net_sched: sfq: allow divisor to be a variable Eric Dumazet
2011-01-20 10:17 ` Eric Dumazet
2011-01-20 13:48 ` [PATCH net-next-2.6] net_sched: RCU conversion of stab Eric Dumazet
2011-01-20 15:01 ` Patrick McHardy
2011-01-20 16:39 ` Eric Dumazet
2011-01-20 15:27 ` [PATCH net-next-2.6] net_sched: move TCQ_F_THROTTLED flag Eric Dumazet
2011-01-21 0:56 ` David Miller
2011-01-21 11:04 ` [PATCH net-next-2.6] net_sched: TCQ_F_CAN_BYPASS generalization Eric Dumazet
2011-01-22 0:27 ` David Miller [this message]
2011-01-21 0:56 ` [PATCH net-next-2.6] net_sched: RCU conversion of stab David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121.162733.123411406.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=hawk@diku.dk \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).