From: Simon Horman <horms@verge.net.au>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>, Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipvs: fix compiler warnings
Date: Sat, 22 Jan 2011 14:12:02 +1100 [thread overview]
Message-ID: <20110122031202.GA9142@verge.net.au> (raw)
In-Reply-To: <20110122031116.GA8443@verge.net.au>
On Sat, Jan 22, 2011 at 02:11:16PM +1100, Simon Horman wrote:
> On Sat, Jan 22, 2011 at 10:34:23AM +0800, Changli Gao wrote:
> > On Sat, Jan 22, 2011 at 10:22 AM, Simon Horman <horms@verge.net.au> wrote:
> > > On Fri, Jan 21, 2011 at 06:02:13PM +0800, Changli Gao wrote:
> > >> Fix compiler warnings when no transport protocol load balancing support
> > >> is configured.
> > >>
> > >> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> > >> ---
> > >> net/netfilter/ipvs/ip_vs_core.c | 4 +---
> > >> net/netfilter/ipvs/ip_vs_ctl.c | 4 ++++
> > >> net/netfilter/ipvs/ip_vs_proto.c | 4 ++++
> > >> 3 files changed, 9 insertions(+), 3 deletions(-)
> > >> diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
> > >> index f36a84f..d889f4f 100644
> > >> --- a/net/netfilter/ipvs/ip_vs_core.c
> > >> +++ b/net/netfilter/ipvs/ip_vs_core.c
> > >> @@ -1894,9 +1894,7 @@ static int __net_init __ip_vs_init(struct net *net)
> > >>
> > >> static void __net_exit __ip_vs_cleanup(struct net *net)
> > >> {
> > >> - struct netns_ipvs *ipvs = net_ipvs(net);
> > >> -
> > >> - IP_VS_DBG(10, "ipvs netns %d released\n", ipvs->gen);
> > >> + IP_VS_DBG(10, "ipvs netns %d released\n", net_ipvs(net)->gen);
> > >> }
> > >>
> > >
> > > The hunk above seems unrelated to the problem described.
> > > The rest of the changes look good. I will double check and
> > > apply them to my tree.
> > >
> >
> > Yes, is a separated patch needed? It is trivial. Thanks.
>
> Yes, please send a separate patch.
To clarify, I have applied the other hunks and included
them in a pull request that I sent to Patrick a few moments ago.
next prev parent reply other threads:[~2011-01-22 3:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 10:02 [PATCH] netfilter: ipvs: fix compiler warnings Changli Gao
2011-01-21 16:50 ` Patrick McHardy
2011-01-22 2:22 ` Simon Horman
2011-01-22 2:34 ` Changli Gao
2011-01-22 3:11 ` Simon Horman
2011-01-22 3:12 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-25 4:40 Changli Gao
2011-01-25 5:05 ` Simon Horman
2011-01-25 10:25 ` Patrick McHardy
2011-01-25 13:09 ` Simon Horman
2011-01-25 13:15 ` Simon Horman
2011-01-25 21:22 ` Julian Anastasov
2011-01-25 13:51 ` Patrick McHardy
2011-01-25 6:49 ` Hans Schillstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110122031202.GA9142@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).