From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: shemminger@vyatta.com, w@1wt.eu, jbohac@suse.cz,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
stable@kernel.org, stephen.hemminger@vyatta.com,
brian.haley@hp.com, lorenzo@google.com, maheshkelkar@gmail.com
Subject: Re: [stable] [RFC] ipv6: don't flush routes when setting loopback down
Date: Sun, 23 Jan 2011 11:57:19 -0800 (PST) [thread overview]
Message-ID: <20110123.115719.39193994.davem@davemloft.net> (raw)
In-Reply-To: <m1k4hv5sue.fsf@fess.ebiederm.org>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Sun, 23 Jan 2011 11:21:29 -0800
> Stephen Hemminger <shemminger@vyatta.com> writes:
>
>> I think this fixes the issue with disable_ipv6
>
> Somehow I doubt deleting the ipv6 state, and removing the per device
> disable_ipv6 flag is going to be backwards compatible.
>
> echo 0 > /proc/sys/net/ipv6/conf/disable_ipv6
>
> Won't work.
>
> What ever other good properties calling NETDEV_UNREGISTER for ipv6
> devices may have.
Don't worry Eric, I'm reverting all of the changes that caused this
problem in the first place.
If Stephen wants his change back in, he'll have to resubmit it in
a working state with all the known regressions dealt with.
next prev parent reply other threads:[~2011-01-23 19:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 0:24 echo > 0 .../disable_ipv6 broken in 2.6.37-rc4 Eric W. Biederman
2010-12-06 0:33 ` Lorenzo Colitti
2010-12-06 0:39 ` Eric W. Biederman
2010-12-06 5:51 ` Eric W. Biederman
2010-12-06 16:10 ` Brian Haley
2010-12-08 21:29 ` Eric W. Biederman
2010-12-08 22:49 ` Brian Haley
2010-12-08 23:13 ` Eric W. Biederman
2010-12-08 23:49 ` Stephen Hemminger
2010-12-09 2:42 ` Eric W. Biederman
2010-12-09 3:18 ` Eric W. Biederman
2010-12-09 4:16 ` [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support Eric W. Biederman
2010-12-09 15:28 ` Brian Haley
2010-12-09 16:27 ` Stephen Hemminger
2010-12-09 19:22 ` Eric W. Biederman
2010-12-09 19:09 ` Eric W. Biederman
2010-12-09 19:16 ` Stephen Hemminger
2010-12-09 19:31 ` Eric W. Biederman
2010-12-09 20:20 ` David Miller
2010-12-09 20:20 ` David Miller
2010-12-09 22:51 ` Stephen Hemminger
2010-12-16 21:28 ` [RFC] ipv6: don't flush routes when setting loopback down Stephen Hemminger
2010-12-16 23:17 ` Eric W. Biederman
2010-12-17 1:18 ` Eric W. Biederman
2010-12-17 2:26 ` David Miller
2011-01-19 19:18 ` Jiri Bohac
2011-01-19 19:38 ` Stephen Hemminger
2011-01-19 19:56 ` Jiri Bohac
2011-01-19 20:01 ` Stephen Hemminger
2011-01-22 8:17 ` Eric W. Biederman
2011-01-22 22:39 ` Stephen Hemminger
2011-01-22 22:54 ` David Miller
2011-01-23 4:41 ` Stephen Hemminger
2011-01-23 5:42 ` David Miller
2011-01-23 8:24 ` Stephen Hemminger
2011-01-23 8:26 ` Stephen Hemminger
2011-01-23 9:15 ` [stable] " Willy Tarreau
2011-01-23 9:21 ` Stephen Hemminger
2011-01-23 10:34 ` Stephen Hemminger
2011-01-23 19:21 ` Eric W. Biederman
2011-01-23 19:57 ` David Miller [this message]
2011-01-23 19:48 ` David Miller
2011-01-23 19:47 ` David Miller
2010-12-10 4:02 ` [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110123.115719.39193994.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brian.haley@hp.com \
--cc=ebiederm@xmission.com \
--cc=jbohac@suse.cz \
--cc=lorenzo@google.com \
--cc=maheshkelkar@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stable@kernel.org \
--cc=stephen.hemminger@vyatta.com \
--cc=w@1wt.eu \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).