From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: stephen.hemminger@vyatta.com, ebiederm@xmission.com,
jbohac@suse.cz, brian.haley@hp.com, netdev@vger.kernel.org,
maheshkelkar@gmail.com, lorenzo@google.com,
yoshfuji@linux-ipv6.org, stable@kernel.org
Subject: Re: [RFC] ipv6: don't flush routes when setting loopback down
Date: Sun, 23 Jan 2011 19:24:16 +1100 [thread overview]
Message-ID: <20110123192416.73cd7521@s6510> (raw)
In-Reply-To: <20110122.214254.226765382.davem@davemloft.net>
On Sat, 22 Jan 2011 21:42:54 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen.hemminger@vyatta.com>
> Date: Sat, 22 Jan 2011 20:41:12 -0800 (PST)
>
> > Having IPv6 remove all addresses when link goes down is fundamentally broken
> > that is what the original problem being fixed. For users on servers or using
> > Quagga this matters, how do you plan to fix that?
>
> How about in a way that doesn't break stuff?
>
> And it's been beyond proven that people give more of a crap
> about disable_ipv6 than the thing you keep claiming is a big deal.
>
> NOBODY other than you even noticed the issue or made a report about
> it.
>
> Yet we have people actively complaining about disable_ipv6 being
> broken.
>
> So you lose on two counts. You can't fix things by breaking other
> stuff, and your obscure stuff matters less than things people
> actually notice being broken.
You are probably so upset because I stepped on code you worked hard
on. But the IPv6 semantics should not have been different from IPv4
and the disable_ipv6 flag was a poor API choice as well. Legacy
API's suck, I don't expect perfection but it should be possible
to make a working version that:
Allows disabling IPv6 completely on an interface
AND Has the same address and route semantics for both
IPv4 and IPv6.
next prev parent reply other threads:[~2011-01-23 8:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 0:24 echo > 0 .../disable_ipv6 broken in 2.6.37-rc4 Eric W. Biederman
2010-12-06 0:33 ` Lorenzo Colitti
2010-12-06 0:39 ` Eric W. Biederman
2010-12-06 5:51 ` Eric W. Biederman
2010-12-06 16:10 ` Brian Haley
2010-12-08 21:29 ` Eric W. Biederman
2010-12-08 22:49 ` Brian Haley
2010-12-08 23:13 ` Eric W. Biederman
2010-12-08 23:49 ` Stephen Hemminger
2010-12-09 2:42 ` Eric W. Biederman
2010-12-09 3:18 ` Eric W. Biederman
2010-12-09 4:16 ` [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support Eric W. Biederman
2010-12-09 15:28 ` Brian Haley
2010-12-09 16:27 ` Stephen Hemminger
2010-12-09 19:22 ` Eric W. Biederman
2010-12-09 19:09 ` Eric W. Biederman
2010-12-09 19:16 ` Stephen Hemminger
2010-12-09 19:31 ` Eric W. Biederman
2010-12-09 20:20 ` David Miller
2010-12-09 20:20 ` David Miller
2010-12-09 22:51 ` Stephen Hemminger
2010-12-16 21:28 ` [RFC] ipv6: don't flush routes when setting loopback down Stephen Hemminger
2010-12-16 23:17 ` Eric W. Biederman
2010-12-17 1:18 ` Eric W. Biederman
2010-12-17 2:26 ` David Miller
2011-01-19 19:18 ` Jiri Bohac
2011-01-19 19:38 ` Stephen Hemminger
2011-01-19 19:56 ` Jiri Bohac
2011-01-19 20:01 ` Stephen Hemminger
2011-01-22 8:17 ` Eric W. Biederman
2011-01-22 22:39 ` Stephen Hemminger
2011-01-22 22:54 ` David Miller
2011-01-23 4:41 ` Stephen Hemminger
2011-01-23 5:42 ` David Miller
2011-01-23 8:24 ` Stephen Hemminger [this message]
2011-01-23 8:26 ` Stephen Hemminger
2011-01-23 9:15 ` [stable] " Willy Tarreau
2011-01-23 9:21 ` Stephen Hemminger
2011-01-23 10:34 ` Stephen Hemminger
2011-01-23 19:21 ` Eric W. Biederman
2011-01-23 19:57 ` [stable] " David Miller
2011-01-23 19:48 ` David Miller
2011-01-23 19:47 ` David Miller
2010-12-10 4:02 ` [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110123192416.73cd7521@s6510 \
--to=shemminger@vyatta.com \
--cc=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jbohac@suse.cz \
--cc=lorenzo@google.com \
--cc=maheshkelkar@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stephen.hemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).