From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jamie@audible.transient.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: 2.6.38-rc1: arp triggers RTNL assertion
Date: Mon, 24 Jan 2011 13:14:02 -0800 (PST) [thread overview]
Message-ID: <20110124.131402.226784705.davem@davemloft.net> (raw)
In-Reply-To: <1295903498.2924.17.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 24 Jan 2011 22:11:38 +0100
> Le vendredi 21 janvier 2011 à 13:06 -0800, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Fri, 21 Jan 2011 19:52:56 +0100
>>
>> > Here is how I fixed this, thanks again Jamie !
>> >
>> > [PATCH] net: neighbour: pneigh_lookup() doesnt need RTNL
>>
>> Eric, I don't think we can do this.
>>
>> Fundamentally, any time a user operation changes the configuration
>> of the networking, we must hold the RTNL.
>>
>> Eliding the RTNL for lookups is fine, but for things that change
>> state it is not.
>>
>> I therefore think you'll need to rework the arp_ioctl() portions
>> of the commit that introduced this regression.
>>
>
> Here is a second try of the fix, thanks !
>
> Note : Tested with CONFIG_PROVE_RCU=y
>
> [PATCH] net: arp_ioctl() must hold RTNL
Thanks Eric, this one looks a lot better. I'll apply this later
tonight.
prev parent reply other threads:[~2011-01-24 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 6:17 2.6.38-rc1: arp triggers RTNL assertion Jamie Heilman
2011-01-21 7:12 ` Eric Dumazet
2011-01-21 14:02 ` Richard Cochran
2011-01-21 18:52 ` Eric Dumazet
2011-01-21 21:06 ` David Miller
2011-01-21 22:13 ` Eric Dumazet
2011-01-24 21:11 ` Eric Dumazet
2011-01-24 21:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124.131402.226784705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jamie@audible.transient.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).