[PATCH] netconsole: kbuild dependency fix

[PATCH] netconsole: kbuild dependency fix

[Stanislav Fomichev]

Hello all,
I'm not sure if it's the right place to send this patch, but I didn't find a better one.

Here is a small fix for netconsole dependency (upon config fs) that I unintentionally found.

Hope you'll find it useful.

This patch is for 2.6.38-rc2.

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 0382332..9733da1 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -3382,6 +3382,7 @@ config NET_FC
 	  "SCSI generic support".
 
 config NETCONSOLE
+	depends on CONFIGFS_FS
 	tristate "Network console logging support"
 	---help---
 	If you want to log kernel messages over the network, enable this.

Re: [PATCH] netconsole: kbuild dependency fix

[David Miller]

From: Stanislav Fomichev <kernel@fomichev.me>
Date: Sun, 23 Jan 2011 22:51:16 +0300

> Hello all,
> I'm not sure if it's the right place to send this patch, but I didn't find a better one.
> 
> Here is a small fix for netconsole dependency (upon config fs) that I unintentionally found.
> 
> Hope you'll find it useful.
> 
> This patch is for 2.6.38-rc2.

Please show the configuration and build error messages from when the
build fails, otherwise we have to guess what causes the dependency.

Secondly, please read "Documentation/SubmittingPatches" to learn how
to properly submit a patch, in particular your submission is missing
a proper "Signed-off-by" line.

Thirdly, you might want to CC: whoever created this dependency or
has been playing out in this area lately so that they can review
you patch and see the mistake they made and thus provide feedback.

Thanks.

Re: [PATCH] netconsole: kbuild dependency fix

[Stanislav Fomichev]

> Please show the configuration and build error messages from when the
> build fails, otherwise we have to guess what causes the dependency.
Hm, I can't reproduce it (the config which caused the error was not saved).
And honestly, looking deeper into the code I can't imagine how could I get
an error here.
So sorry for confusing you.