public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] pktgen: speedup fragmented skbs
Date: Tue, 25 Jan 2011 13:26:26 -0800 (PST)	[thread overview]
Message-ID: <20110125.132626.39178379.davem@davemloft.net> (raw)
In-Reply-To: <1295975635.3588.337.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 25 Jan 2011 18:13:55 +0100

> We spend lot of time clearing pages in pktgen.
> (Or not clearing them on ipv6 and leaking kernel memory)
> 
> Since we dont modify them, we can use one zeroed page, and get
> references on it. This page can use NUMA affinity as well.
> 
> Define pktgen_finalize_skb() helper, used both in ipv4 and ipv6
> 
> Results using skbs with one frag :
> 
> Before patch :
> 
> Result: OK: 608980458(c608978520+d1938) nsec, 1000000000
> (100byte,1frags)
>   1642088pps 1313Mb/sec (1313670400bps) errors: 0
> 
> After patch :
> 
> Result: OK: 345285014(c345283891+d1123) nsec, 1000000000
> (100byte,1frags)
>   2896158pps 2316Mb/sec (2316926400bps) errors: 0
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied, although I changed "->page = 0;" to "->page = NULL;"

Thanks!

  parent reply	other threads:[~2011-01-25 21:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 17:13 [PATCH net-next-2.6] pktgen: speedup fragmented skbs Eric Dumazet
2011-01-25 17:22 ` Ben Greear
2011-01-25 17:47   ` Eric Dumazet
2011-01-25 21:26 ` David Miller [this message]
2011-01-25 21:36   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110125.132626.39178379.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox