From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org
Cc: nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3] smc91x: add devicetree support
Date: Tue, 25 Jan 2011 19:45:32 -0800 (PST) [thread overview]
Message-ID: <20110125.194532.71125517.davem@davemloft.net> (raw)
In-Reply-To: <1295957508-2701-1-git-send-email-thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
From: Thomas Chou <thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
Date: Tue, 25 Jan 2011 20:11:48 +0800
> @@ -2394,6 +2395,13 @@ static int smc_drv_resume(struct device *dev)
> return 0;
> }
>
> +static const struct of_device_id smc91x_match[] = {
> + { .compatible = "smsc,lan91c94", },
> + { .compatible = "smsc,lan91c111", },
> + {},
> +}
> +MODULE_DEVICE_TABLE(of, smc91x_match);
> +
> static struct dev_pm_ops smc_drv_pm_ops = {
> .suspend = smc_drv_suspend,
> .resume = smc_drv_resume,
You should not unconditionally put the 'of' device table into the
module image, otherwise the module will be marked as being able to
support OF based devices but the code to support that won't actually
be comiled into the module.
next prev parent reply other threads:[~2011-01-26 3:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 5:59 [PATCH] smc91x: add devicetree support Thomas Chou
[not found] ` <1295935170-19518-1-git-send-email-thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
2011-01-25 6:24 ` Grant Likely
[not found] ` <AANLkTikgsqJqdW2qh7h4yATCmGFb5MkHCosma_DOBq-Y-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-25 7:09 ` [PATCH v2] " Thomas Chou
2011-01-25 12:11 ` [PATCH v3] " Thomas Chou
[not found] ` <1295957508-2701-1-git-send-email-thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
2011-01-26 3:45 ` David Miller [this message]
[not found] ` <20110125.194532.71125517.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-01-26 5:22 ` [PATCH v4] " Thomas Chou
[not found] ` <1296019325-17801-1-git-send-email-thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
2011-01-26 5:52 ` Grant Likely
[not found] ` <AANLkTindbigYzY0zJufpr-D25m_B5Gjqp09ZbcaN-aZ9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-26 6:42 ` David Miller
2011-01-26 15:17 ` Nicolas Pitre
[not found] ` <alpine.LFD.2.00.1101261004560.8580-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2011-01-26 15:32 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125.194532.71125517.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org \
--cc=thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).