netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: leitao@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] bnx2: Eliminate AER error messages on systems not supporting it
Date: Wed, 26 Jan 2011 14:28:22 -0800 (PST)	[thread overview]
Message-ID: <20110126.142822.115949432.davem@davemloft.net> (raw)
In-Reply-To: <20110126.142635.59692241.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 26 Jan 2011 14:26:35 -0800 (PST)

> From: "Michael Chan" <mchan@broadcom.com>
> Date: Wed, 26 Jan 2011 00:14:51 -0800
> 
>> On PPC for example, AER is not supported and we see unnecessary AER
>> error message without this patch:
>> 
>> bnx2 0003:01:00.1: pci_cleanup_aer_uncorrect_error_status failed 0xfffffffb
>> 
>> Reported-by: Breno Leitao <leitao@linux.vnet.ibm.com>
>> Signed-off-by: Michael Chan <mchan@broadcom.com>
> 
> Applied.

Please check for warnings in your build, I ammended the following fix
into this commit:

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 62c6079..0ba59d5 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -8540,7 +8540,7 @@ static pci_ers_result_t bnx2_io_slot_reset(struct pci_dev *pdev)
 	}
 	rtnl_unlock();
 
-	if (!bp->flags & BNX2_FLAG_AER_ENABLED)
+	if (!(bp->flags & BNX2_FLAG_AER_ENABLED))
 		return result;
 
 	err = pci_cleanup_aer_uncorrect_error_status(pdev);

  reply	other threads:[~2011-01-26 22:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  8:14 [PATCH net-2.6] cnic: Fix big endian bug Michael Chan
2011-01-26  8:14 ` [PATCH net-2.6] bnx2: Eliminate AER error messages on systems not supporting it Michael Chan
2011-01-26 22:26   ` David Miller
2011-01-26 22:28     ` David Miller [this message]
2011-01-26 22:26 ` [PATCH net-2.6] cnic: Fix big endian bug David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110126.142822.115949432.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=leitao@linux.vnet.ibm.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).