From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-2.6] bnx2: Eliminate AER error messages on systems not supporting it Date: Wed, 26 Jan 2011 14:28:22 -0800 (PST) Message-ID: <20110126.142822.115949432.davem@davemloft.net> References: <1296029691-3591-1-git-send-email-mchan@broadcom.com> <1296029691-3591-2-git-send-email-mchan@broadcom.com> <20110126.142635.59692241.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: leitao@linux.vnet.ibm.com, netdev@vger.kernel.org To: mchan@broadcom.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:44065 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753338Ab1AZW1r (ORCPT ); Wed, 26 Jan 2011 17:27:47 -0500 In-Reply-To: <20110126.142635.59692241.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: From: David Miller Date: Wed, 26 Jan 2011 14:26:35 -0800 (PST) > From: "Michael Chan" > Date: Wed, 26 Jan 2011 00:14:51 -0800 > >> On PPC for example, AER is not supported and we see unnecessary AER >> error message without this patch: >> >> bnx2 0003:01:00.1: pci_cleanup_aer_uncorrect_error_status failed 0xfffffffb >> >> Reported-by: Breno Leitao >> Signed-off-by: Michael Chan > > Applied. Please check for warnings in your build, I ammended the following fix into this commit: diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 62c6079..0ba59d5 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -8540,7 +8540,7 @@ static pci_ers_result_t bnx2_io_slot_reset(struct pci_dev *pdev) } rtnl_unlock(); - if (!bp->flags & BNX2_FLAG_AER_ENABLED) + if (!(bp->flags & BNX2_FLAG_AER_ENABLED)) return result; err = pci_cleanup_aer_uncorrect_error_status(pdev);