From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ralf Baechle <ralf@linux-mips.org>,
Kyle McMartin <kyle@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
x86@kernel.org, linux-arch@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] kconfig: unify GENERIC_ISA_DMA and ISA_DMA_API
Date: Wed, 26 Jan 2011 11:29:08 +0000 [thread overview]
Message-ID: <20110126112908.GD2562@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1101251706040.9641@chino.kir.corp.google.com>
On Tue, Jan 25, 2011 at 05:06:28PM -0800, David Rientjes wrote:
> CONFIG_GENERIC_ISA_DMA and CONFIG_ISA_DMA_API usually have dependencies
> on one another depending on the architecture and generic kernel code uses
> either to determine whether an ISA-style DMA API is configured.
Wrong.
GENERIC_ISA_DMA enables support for the standard ISA DMA allocator found
in kernel/dma.c
ISA_DMA_API says that a platform supports the ISA DMA interfaces.
An architecture can provide the ISA DMA interfaces, but not use the
standard ISA DMA allocator found in kernel/dma.c. Such as the one in
arch/arm/kernel/dma.c.
So on ARM, we have platforms where ISA_DMA_API=y but GENERIC_ISA_DMA=n.
> This patch unifies both options and consolidates them into a single
> option: CONFIG_GENERIC_ISA_DMA. It is also a prerequisite for a 1% text
> savings for a future x86 patch that allows these options to be disabled
> on that architecture when CONFIG_ZONE_DMA also becomes configurable.
NAK. This is wrong.
next prev parent reply other threads:[~2011-01-26 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 1:06 [patch] kconfig: unify GENERIC_ISA_DMA and ISA_DMA_API David Rientjes
2011-01-26 11:29 ` Russell King - ARM Linux [this message]
2011-01-26 20:00 ` David Rientjes
2011-01-26 20:10 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126112908.GD2562@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=kyle@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=randy.dunlap@oracle.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).