From: David Miller <davem@davemloft.net>
To: ian.campbell@citrix.com
Cc: netdev@vger.kernel.org, jeremy@goop.org, xen-devel@lists.xensource.com
Subject: Re: [PATCH] xen: netfront: handle incoming GSO SKBs which are not CHECKSUM_PARTIAL
Date: Thu, 27 Jan 2011 14:23:48 -0800 (PST) [thread overview]
Message-ID: <20110127.142348.39184559.davem@davemloft.net> (raw)
In-Reply-To: <1296137643-24814-1-git-send-email-ian.campbell@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Thu, 27 Jan 2011 14:14:03 +0000
> The Linux network stack expects all GSO SKBs to have ip_summed ==
> CHECKSUM_PARTIAL (which implies that the frame contains a partial
> checksum) and the Xen network ring protocol similarly expects an SKB
> which has GSO set to also have NETRX_csum_blank (which also implies a
> partial checksum).
>
> However there have been cases of buggy guests which mark a frame as
> GSO but do not set csum_blank. If we detect that we a receiving such a
> frame (which manifests as ip_summed != PARTIAL && skb_is_gso) then
> force the SKB to partial and recalculate the checksum, since we cannot
> rely on the peer having done so if they have not set csum_blank.
>
> Add an ethtool stat to track occurances of this event.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Looks great, applied, thanks Ian.
prev parent reply other threads:[~2011-01-27 22:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 13:23 [PATCH] xen: netfront: Drop GSO SKBs which do not have csum_blank Ian Campbell
2011-01-11 11:46 ` Ian Campbell
2011-01-22 0:58 ` Jeremy Fitzhardinge
2011-01-22 9:43 ` Ian Campbell
2011-01-24 17:55 ` Jeremy Fitzhardinge
2011-01-25 17:09 ` Ian Campbell
2011-01-25 17:09 ` [PATCH 1/2] xen: netfront: refactor code for checking validity of incoming skbs Ian Campbell
2011-01-25 17:10 ` [PATCH 2/2] xen: netfront: Drop GSO SKBs which do not have csum_blank Ian Campbell
2011-01-26 3:44 ` David Miller
2011-01-26 11:56 ` Ian Campbell
2011-01-27 14:14 ` [PATCH] xen: netfront: handle incoming GSO SKBs which are not CHECKSUM_PARTIAL Ian Campbell
2011-01-27 22:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127.142348.39184559.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).