From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: amir.hanania@intel.com, netdev@vger.kernel.org, gospo@redhat.com,
bphilips@novell.com
Subject: Re: [net-2.6 v2 5/7] ixgbe: DDP last buffer size work around
Date: Fri, 28 Jan 2011 11:51:00 -0800 (PST) [thread overview]
Message-ID: <20110128.115100.226772144.davem@davemloft.net> (raw)
In-Reply-To: <1296217743-30093-6-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 28 Jan 2011 04:29:01 -0800
> From: Amir Hanania <amir.hanania@intel.com>
>
> We found a hardware erratum on 82599 hardware that can lead to buffer
> overwriting if the last buffer in FCoE DDP is exactly PAGE_SIZE.
> If this is the case, we will make sure that there is no HW access to
> this buffer.
>
> Please see the 82599 Specification Update for more information.
>
> Signed-off-by: Amir Hanania <amir.hanania@intel.com>
> Tested-by: Ross Brattain <ross.b.brattain@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Jeff, I still think this change is bogus.
PAGE_SIZE is variable, so the chip can't possibly only BUG on that
specific value.
Maybe the condition is "any power-of-2 larger than or equal to 4096"?
Or something like that?
I pointed this out last night, and I was really hoping I'd get actual
feedback on this issue before you're respin your tree.
I'm not pulling in these changes until I get a human being telling me
what the situation is here with this bug.
next prev parent reply other threads:[~2011-01-28 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 12:28 [net-2.6 v2 0/7][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-01-28 12:28 ` [net-2.6 v2 1/7] e1000: add support for Marvell Alaska M88E1118R PHY Jeff Kirsher
2011-01-28 12:28 ` [net-2.6 v2 2/7] ixgbe: fix variable set but not used warnings by gcc 4.6 Jeff Kirsher
2011-01-28 12:28 ` [net-2.6 v2 3/7] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
2011-01-28 12:29 ` [net-2.6 v2 4/7] ixgbe: limit VF access to network traffic Jeff Kirsher
2011-01-28 12:29 ` [net-2.6 v2 5/7] ixgbe: DDP last buffer size work around Jeff Kirsher
2011-01-28 19:51 ` David Miller [this message]
2011-01-28 21:36 ` Hanania, Amir
2011-01-28 21:45 ` David Miller
2011-01-28 12:29 ` [net-2.6 v2 6/7] ixgbe: cleanup variable initialization Jeff Kirsher
2011-01-28 12:29 ` [net-2.6 v2 7/7] ixgbe: update version string Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128.115100.226772144.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amir.hanania@intel.com \
--cc=bphilips@novell.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).