From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: lior.levy@intel.com, netdev@vger.kernel.org, gospo@redhat.com,
bphilips@novell.com
Subject: Re: [net-next-2.6 2/3] igb: add support for VF Transmit rate limit using iproute2
Date: Fri, 28 Jan 2011 16:38:17 -0800 (PST) [thread overview]
Message-ID: <20110128.163817.193721063.davem@davemloft.net> (raw)
In-Reply-To: <1296217779-30133-3-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 28 Jan 2011 04:29:38 -0800
> + if (tx_rate != 0)
> + dev_info(&adapter->pdev->dev,
> + "Setting Transmit rate of %d Mbps for VF %d\n",
> + tx_rate, vf);
> + else
> + dev_info(&adapter->pdev->dev,
> + "Transmit rate limit for VF %d is disabled\n", vf);
If you're going to print this, use netdev_info(netdev, ...).
But I think you shouldn't be logging anything at all.
No other ethtool operation logs what it did except in extremely
exceptional error conditions. And there is nothing special
about this VF rate limiting ethtool operation to justify these
extraneous logging messages.
If people want to know if the VF is rate limited, and by how much,
then can query the configuration using ethtool.
next prev parent reply other threads:[~2011-01-29 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 12:29 [net-next-2.6 0/3][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-01-28 12:29 ` [net-next-2.6 1/3] igb: Enable PF side of SR-IOV support for i350 devices Jeff Kirsher
2011-01-28 12:29 ` [net-next-2.6 2/3] igb: add support for VF Transmit rate limit using iproute2 Jeff Kirsher
2011-01-29 0:38 ` David Miller [this message]
2011-02-07 18:08 ` Levy, Lior
2011-01-28 12:29 ` [net-next-2.6 3/3] ixgbe: Adding 100MB FULL support in ethtool Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128.163817.193721063.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=lior.levy@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).