public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, Hayes <hayeswang@realtek.com>
Subject: Re: [PATCH] r8169: use RxFIFO overflow workaround for 8168c chipset
Date: Fri, 28 Jan 2011 18:28:55 +0100	[thread overview]
Message-ID: <20110128172854.GA8151@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20110128172537.GA11064@electric-eye.fr.zoreil.com>

Ivan Vecera <ivecera@redhat.com> :
[...]
> The test case was: Migration of the several kvm guests at the same time
> between two hosts.

:o(

Could you check if simply leaving the irq handler when status == RxFIFOOver
works by any chance ?

Faced with pktgen, RTL_GIGA_MAC_VER_26 spits RxFIFO overflow errors quite
fast (10000 packets kill it, reliably). The same fix as your avoids the crash.

As is, RTL_GIGA_MAC_VER_12 seems to survive at 900kpps. It signals RXFIFO
overflow, loses half the packets and sends pause control frames but it does
not crash. I have made it leave the irq handler when status == RxFIFOOver.
I'll see if it can stand a few hours like that.

-- 
Ueimor

  parent reply	other threads:[~2011-01-28 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 11:24 [PATCH] r8169: use RxFIFO overflow workaround for 8168c chipset Ivan Vecera
2011-01-27 11:27 ` Ivan Vecera
2011-01-27 14:32 ` Francois Romieu
2011-01-27 19:23   ` Ivan Vecera
     [not found]     ` <20110128172537.GA11064@electric-eye.fr.zoreil.com>
2011-01-28 17:28       ` Francois Romieu [this message]
2011-02-01 10:30         ` Ivan Vecera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110128172854.GA8151@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=hayeswang@realtek.com \
    --cc=ivecera@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox