From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, kaber@trash.net
Subject: Re: [PATCH] net: Add compat ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT
Date: Sun, 30 Jan 2011 01:14:58 -0800 (PST) [thread overview]
Message-ID: <20110130.011458.183048917.davem@davemloft.net> (raw)
In-Reply-To: <m18vy3uof7.fsf@fess.ebiederm.org>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Sat, 29 Jan 2011 18:15:56 -0800
>
> SIOCGETSGCNT is not a unique ioctl value as it it maps tio SIOCPROTOPRIVATE +1,
> which unfortunately means the existing infrastructure for compat networking
> ioctls is insufficient. A trivial compact ioctl implementation would conflict
> with:
>
> SIOCAX25ADDUID
> SIOCAIPXPRISLT
> SIOCGETSGCNT_IN6
> SIOCGETSGCNT
> SIOCRSSCAUSE
> SIOCX25SSUBSCRIP
> SIOCX25SDTEFACILITIES
>
> To make this work I have updated the compat_ioctl decode path to mirror the
> the normal ioctl decode path. I have added an ipv4 inet_compat_ioctl function
> so that I can have ipv4 specific compat ioctls. I have added a compat_ioctl
> function into struct proto so I can break out ioctls by which kind of ip socket
> I am using. I have added a compat_raw_ioctl function because SIOCGETSGCNT only
> works on raw sockets. I have added a ipmr_compat_ioctl that mirrors the normal
> ipmr_ioctl.
>
> This was necessary because unfortunately the struct layout for the SIOCGETSGCNT
> has unsigned longs in it so changes between 32bit and 64bit kernels.
>
> This change was sufficient to run a 32bit ip multicast routing daemon on a
> 64bit kernel.
>
> Reported-by: Bill Fenner <fenner@aristanetworks.com>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Thanks a lot for doing this work Eric, applied to net-2.6.
next prev parent reply other threads:[~2011-01-30 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 2:15 [PATCH] net: Add compat ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT Eric W. Biederman
2011-01-30 9:14 ` David Miller [this message]
2011-01-30 12:26 ` Arnd Bergmann
2011-01-30 18:15 ` Eric W. Biederman
2011-01-30 18:59 ` Arnd Bergmann
2011-02-04 1:19 ` David Miller
2011-02-04 2:07 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110130.011458.183048917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).