From: David Miller <davem@davemloft.net>
To: john.r.fastabend@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field with 802.1Qaz spec
Date: Mon, 31 Jan 2011 20:41:04 -0800 (PST) [thread overview]
Message-ID: <20110131.204104.226756946.davem@davemloft.net> (raw)
In-Reply-To: <20110131220048.29758.22379.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Mon, 31 Jan 2011 14:00:49 -0800
> The dcb_app protocol field is a __u32 however the 802.1Qaz
> specification defines it as a 16 bit field. This patch brings
> the structure inline with the spec making it a __u16.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
...
> @@ -101,7 +101,7 @@ struct ieee_pfc {
> */
> struct dcb_app {
> __u8 selector;
> - __u32 protocol;
> + __u16 protocol;
> __u8 priority;
> };
>
If we're going to do this, please fix this wasteful structure
layout. Put the "protocol" either first, or last, so that the
structure size is 4 bytes, rather than something like 8.
next prev parent reply other threads:[~2011-02-01 4:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 22:00 [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field with 802.1Qaz spec John Fastabend
2011-01-31 22:00 ` [net-2.6 PATCH 2/3] net: dcb: use _safe() version of list iterators John Fastabend
2011-02-01 4:42 ` David Miller
2011-02-05 19:40 ` John Fastabend
2011-01-31 22:00 ` [net-2.6 PATCH 3/3] net: dcb: application priority is per net_device John Fastabend
2011-02-01 4:43 ` David Miller
2011-02-13 19:03 ` David Miller
2011-02-01 4:41 ` David Miller [this message]
2011-02-05 19:39 ` [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field with 802.1Qaz spec John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110131.204104.226756946.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).