From: David Miller <davem@davemloft.net>
To: weil@mail.berlios.de
Cc: jon.mason@exar.com, ramkrishna.vepa@exar.com,
sivakumar.subramani@exar.com, sreenivasa.honnur@exar.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vxge: Fix wrong boolean operator
Date: Mon, 31 Jan 2011 20:55:53 -0800 (PST) [thread overview]
Message-ID: <20110131.205553.39195952.davem@davemloft.net> (raw)
In-Reply-To: <1296253817-7668-1-git-send-email-weil@mail.berlios.de>
From: Stefan Weil <weil@mail.berlios.de>
Date: Fri, 28 Jan 2011 23:30:17 +0100
> This error is reported by cppcheck:
> drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?
>
> It looks like cppcheck is correct, so fix this. No test was run.
>
> Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@exar.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
> Cc: Jon Mason <jon.mason@exar.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Can the VXGE folks please review this patch?
next prev parent reply other threads:[~2011-02-01 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 22:30 [PATCH] vxge: Fix wrong boolean operator Stefan Weil
2011-02-01 4:55 ` David Miller [this message]
2011-02-01 7:26 ` [PATCH] vxge: Fix wrong boolean operator {nodisc} Ramkrishna Vepa
2011-02-01 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110131.205553.39195952.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.mason@exar.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ramkrishna.vepa@exar.com \
--cc=sivakumar.subramani@exar.com \
--cc=sreenivasa.honnur@exar.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).