From: David Miller <davem@davemloft.net>
To: Ramkrishna.Vepa@exar.com
Cc: weil@mail.berlios.de, Sivakumar.Subramani@exar.com,
Sreenivasa.Honnur@exar.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jon.Mason@exar.com
Subject: Re: [PATCH] vxge: Fix wrong boolean operator {nodisc}
Date: Tue, 01 Feb 2011 12:30:12 -0800 (PST) [thread overview]
Message-ID: <20110201.123012.193709953.davem@davemloft.net> (raw)
In-Reply-To: <FCA91A92EE52B041906A0358FC28FCC38EFBE64996@FRE1EXCH02.hq.exar.com>
From: Ramkrishna Vepa <Ramkrishna.Vepa@exar.com>
Date: Mon, 31 Jan 2011 23:26:40 -0800
>> This error is reported by cppcheck:
>> drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
>> always evaluates to true. Did you intend to use && instead?
>>
>> It looks like cppcheck is correct, so fix this. No test was run.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
...
> Fix looks good. Thanks!
>
> Acked-by: Ram Vepa <ram.vepa@exar.com>
Thanks for reviewing, applied.
prev parent reply other threads:[~2011-02-01 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 22:30 [PATCH] vxge: Fix wrong boolean operator Stefan Weil
2011-02-01 4:55 ` David Miller
2011-02-01 7:26 ` [PATCH] vxge: Fix wrong boolean operator {nodisc} Ramkrishna Vepa
2011-02-01 20:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201.123012.193709953.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jon.Mason@exar.com \
--cc=Ramkrishna.Vepa@exar.com \
--cc=Sivakumar.Subramani@exar.com \
--cc=Sreenivasa.Honnur@exar.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).