* [PATCH net-2.6] bnx2x: multicasts in NPAR mode
@ 2011-02-01 10:57 Vlad Zolotarov
2011-02-01 22:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vlad Zolotarov @ 2011-02-01 10:57 UTC (permalink / raw)
To: davem@davemloft.net, netdev@vger.kernel.org, Eilon Greenstein
The chip was erroneously configured to accept all multicast frames
in a normal (none-promisc) rx mode both on the RSS and on the FCoE L2 rings
when in an NPAR mode. This caused packet duplication for every received multicast
frame in this mode.
Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x/bnx2x_main.c | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
index 404d93e..f40740e 100644
--- a/drivers/net/bnx2x/bnx2x_main.c
+++ b/drivers/net/bnx2x/bnx2x_main.c
@@ -2301,15 +2301,10 @@ static void bnx2x_rxq_set_mac_filters(struct bnx2x *bp, u16 cl_id, u32 filters)
/* accept matched ucast */
drop_all_ucast = 0;
}
- if (filters & BNX2X_ACCEPT_MULTICAST) {
+ if (filters & BNX2X_ACCEPT_MULTICAST)
/* accept matched mcast */
drop_all_mcast = 0;
- if (IS_MF_SI(bp))
- /* since mcast addresses won't arrive with ovlan,
- * fw needs to accept all of them in
- * switch-independent mode */
- accp_all_mcast = 1;
- }
+
if (filters & BNX2X_ACCEPT_ALL_UNICAST) {
/* accept all mcast */
drop_all_ucast = 0;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6] bnx2x: multicasts in NPAR mode
2011-02-01 10:57 [PATCH net-2.6] bnx2x: multicasts in NPAR mode Vlad Zolotarov
@ 2011-02-01 22:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-02-01 22:05 UTC (permalink / raw)
To: vladz; +Cc: netdev, eilong
From: "Vlad Zolotarov" <vladz@broadcom.com>
Date: Tue, 1 Feb 2011 12:57:10 +0200
> The chip was erroneously configured to accept all multicast frames
> in a normal (none-promisc) rx mode both on the RSS and on the FCoE L2 rings
> when in an NPAR mode. This caused packet duplication for every received multicast
> frame in this mode.
>
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks Vlad.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-01 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-01 10:57 [PATCH net-2.6] bnx2x: multicasts in NPAR mode Vlad Zolotarov
2011-02-01 22:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).