From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Remove fib_hash.
Date: Tue, 01 Feb 2011 15:35:04 -0800 (PST) [thread overview]
Message-ID: <20110201.153504.260089860.davem@davemloft.net> (raw)
In-Reply-To: <20110201153332.46a38ad8@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 1 Feb 2011 15:33:32 -0800
> On Tue, 1 Feb 2011 15:26:03 -0800
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
>> On Tue, 01 Feb 2011 15:19:41 -0800 (PST)
>> David Miller <davem@davemloft.net> wrote:
>>
>> >
>> > The time has finally come to remove the hash based routing table
>> > implementation in ipv4.
>> >
>> > FIB Trie is mature, well tested, and I've done an audit of it's code
>> > to confirm that it implements insert, delete, and lookup with the same
>> > identical semantics as fib_hash did.
>> >
>> > If there are any semantic differences found in fib_trie, we should
>> > simply fix them.
>> >
>> > I've placed the trie statistic config option under advanced router
>> > configuration.
>> >
>> > Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>> Vyatta has been shipping FIB TRIE for over 3 years with reported
>> bugs.
>
> NO reported bugs!!
Understood. :-)
Thanks for reviewing Stephen.
next prev parent reply other threads:[~2011-02-01 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 23:19 [PATCH] ipv4: Remove fib_hash David Miller
2011-02-01 23:26 ` Stephen Hemminger
2011-02-01 23:33 ` Stephen Hemminger
2011-02-01 23:35 ` David Miller [this message]
2011-02-02 0:48 ` Eric Dumazet
2011-02-02 2:15 ` David Miller
2011-02-02 16:29 ` Stephen Hemminger
2011-02-02 21:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201.153504.260089860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).