* Re: linux-next: Tree for January 31 (ip_vs)
[not found] <20110131174113.8199f901.sfr@canb.auug.org.au>
@ 2011-01-31 18:18 ` Randy Dunlap
2011-01-31 21:18 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2011-01-31 18:18 UTC (permalink / raw)
To: Stephen Rothwell, netdev; +Cc: linux-next, LKML
On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20110121:
>
> The net tree lost its build failure.
When CONFIG_SYSCTL is not enabled:
net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 31 (ip_vs)
2011-01-31 18:18 ` linux-next: Tree for January 31 (ip_vs) Randy Dunlap
@ 2011-01-31 21:18 ` Simon Horman
2011-01-31 22:57 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2011-01-31 21:18 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML
On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
> On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20110121:
> >
> > The net tree lost its build failure.
>
>
> When CONFIG_SYSCTL is not enabled:
>
> net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
Thanks, I'm looking into it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 31 (ip_vs)
2011-01-31 21:18 ` Simon Horman
@ 2011-01-31 22:57 ` Simon Horman
2011-01-31 23:00 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2011-01-31 22:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML
On Tue, Feb 01, 2011 at 08:18:47AM +1100, Simon Horman wrote:
> On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
> > On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Changes since 20110121:
> > >
> > > The net tree lost its build failure.
> >
> >
> > When CONFIG_SYSCTL is not enabled:
> >
> > net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> > ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> > ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>
> Thanks, I'm looking into it.
On a related note, does IPVS need to handle the case
where CONFIG_PROC_FS is not enabled?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 31 (ip_vs)
2011-01-31 22:57 ` Simon Horman
@ 2011-01-31 23:00 ` David Miller
2011-02-01 0:03 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-01-31 23:00 UTC (permalink / raw)
To: horms; +Cc: randy.dunlap, sfr, netdev, linux-next, linux-kernel
From: Simon Horman <horms@verge.net.au>
Date: Tue, 1 Feb 2011 09:57:28 +1100
> On Tue, Feb 01, 2011 at 08:18:47AM +1100, Simon Horman wrote:
>> On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
>> > On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
>> >
>> > > Hi all,
>> > >
>> > > Changes since 20110121:
>> > >
>> > > The net tree lost its build failure.
>> >
>> >
>> > When CONFIG_SYSCTL is not enabled:
>> >
>> > net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
>> > ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>> > ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>>
>> Thanks, I'm looking into it.
>
> On a related note, does IPVS need to handle the case
> where CONFIG_PROC_FS is not enabled?
Yes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 31 (ip_vs)
2011-01-31 23:00 ` David Miller
@ 2011-02-01 0:03 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2011-02-01 0:03 UTC (permalink / raw)
To: David Miller; +Cc: randy.dunlap, sfr, netdev, linux-next, linux-kernel
On Mon, Jan 31, 2011 at 03:00:31PM -0800, David Miller wrote:
> From: Simon Horman <horms@verge.net.au>
> Date: Tue, 1 Feb 2011 09:57:28 +1100
>
> > On Tue, Feb 01, 2011 at 08:18:47AM +1100, Simon Horman wrote:
> >> On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
> >> > On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
> >> >
> >> > > Hi all,
> >> > >
> >> > > Changes since 20110121:
> >> > >
> >> > > The net tree lost its build failure.
> >> >
> >> >
> >> > When CONFIG_SYSCTL is not enabled:
> >> >
> >> > net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> >> > ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> >> > ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> >>
> >> Thanks, I'm looking into it.
> >
> > On a related note, does IPVS need to handle the case
> > where CONFIG_PROC_FS is not enabled?
>
> Yes.
Thanks.
I checked and it does seem to compile without CONFIG_PROC_FS
and now also without CONFIG_SYSCTL, I'll send a patch for that right
after I finish this email.
I think that in both cases there is dead code, I'll clean that up next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-02-01 0:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110131174113.8199f901.sfr@canb.auug.org.au>
2011-01-31 18:18 ` linux-next: Tree for January 31 (ip_vs) Randy Dunlap
2011-01-31 21:18 ` Simon Horman
2011-01-31 22:57 ` Simon Horman
2011-01-31 23:00 ` David Miller
2011-02-01 0:03 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).