From mboxrd@z Thu Jan 1 00:00:00 1970 From: frank.blaschka@de.ibm.com Subject: [patch 7/7] [PATCH] s390: Fix possibly wrong size in strncmp (smsgiucv) Date: Tue, 01 Feb 2011 09:16:54 +0100 Message-ID: <20110201081724.199388307@de.ibm.com> References: <20110201081647.173934635@de.ibm.com> Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, Stefan Weil To: davem@davemloft.net Return-path: Received: from mtagate7.uk.ibm.com ([194.196.100.167]:51880 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540Ab1BAIRg (ORCPT ); Tue, 1 Feb 2011 03:17:36 -0500 Content-Disposition: inline; filename=610-smsgiucv-strncmp-size.diff Sender: netdev-owner@vger.kernel.org List-ID: From: Stefan Weil This error was reported by cppcheck: drivers/s390/net/smsgiucv.c:63: error: Using sizeof for array given as function argument returns the size of pointer. Although there is no runtime problem as long as sizeof(u8 *) == 8, this misleading code should get fixed. Signed-off-by: Stefan Weil Signed-off-by: Frank Blaschka --- drivers/s390/net/smsgiucv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/s390/net/smsgiucv.c +++ b/drivers/s390/net/smsgiucv.c @@ -60,7 +60,7 @@ static struct iucv_handler smsg_handler static int smsg_path_pending(struct iucv_path *path, u8 ipvmid[8], u8 ipuser[16]) { - if (strncmp(ipvmid, "*MSG ", sizeof(ipvmid)) != 0) + if (strncmp(ipvmid, "*MSG ", 8) != 0) return -EINVAL; /* Path pending from *MSG. */ return iucv_path_accept(path, &smsg_handler, "SMSGIUCV ", NULL);