From: Julien Aube <j.aube@laposte.net>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] IPv6 configurable default value for the privacy extension flag
Date: Tue, 1 Feb 2011 13:57:10 +0100 [thread overview]
Message-ID: <20110201135710.0d7c5a54@baileys.at.home> (raw)
In-Reply-To: <4D478655.6040706@linux-ipv6.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le Tue, 01 Feb 2011 13:04:37 +0900,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> a écrit :
> Hello.
>
> (2011/02/01 0:49), Julien Aube wrote:
>
> >+ } else {
> >+ printk(KERN_WARNING "IPv6 Privacy Extension "
> >+ "is disabled by default (invalid value %d)\n", ipv6_default_privacy);
> >+ }
>
> I think WARNING is too high.
I did put KERN_WARNING because this code is used when someone explicitly set
an invalid value, e.g.
ipv6.privacy_default=-1
But you're right, I'll set KERN_NOTICE instead.
What do you think of the idea by itself anyhow ?
Thanks for the feedback.
Julien
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAk1IAyYACgkQHiz1mD2sU8g39QCg6FY8LFCBwyX310cAZYdyVHJA
a4wAoOSDXBZGgayReuZ5wvzE7iZRiHZr
=7i5B
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2011-02-01 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 15:49 [PATCH] IPv6 configurable default value for the privacy extension flag Julien Aubé
2011-02-01 4:04 ` YOSHIFUJI Hideaki
2011-02-01 12:57 ` Julien Aube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201135710.0d7c5a54@baileys.at.home \
--to=j.aube@laposte.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).