* [PATCH] sis900: Fix mem leak in sis900_rx error path
@ 2011-02-05 20:41 Jesper Juhl
2011-02-06 2:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2011-02-05 20:41 UTC (permalink / raw)
To: Daniele Venzano; +Cc: netdev, linux-kernel
Fix memory leak in error path of sis900_rx(). If we don't do this we'll
leak the skb we dev_alloc_skb()'ed just a few lines above when the
variable goes out of scope.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
sis900.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c
index 5976d1d..640e368 100644
--- a/drivers/net/sis900.c
+++ b/drivers/net/sis900.c
@@ -1777,6 +1777,7 @@ static int sis900_rx(struct net_device *net_dev)
"cur_rx:%4.4d, dirty_rx:%4.4d\n",
net_dev->name, sis_priv->cur_rx,
sis_priv->dirty_rx);
+ dev_kfree_skb(skb);
break;
}
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-06 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-05 20:41 [PATCH] sis900: Fix mem leak in sis900_rx error path Jesper Juhl
2011-02-06 2:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).