From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
cz-bobek-lists-aranym@lists.bobek.cz,
schmitz@opal.biophys.uni-duesseldorf.de, pstehlik@sophics.cz,
M.Jurik@sh.cvut.cz, netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] m68k/atari: ARAnyM - Add support for network access
Date: Sun, 06 Feb 2011 11:17:05 -0800 (PST) [thread overview]
Message-ID: <20110206.111705.183051866.davem@davemloft.net> (raw)
In-Reply-To: <1296989469-7844-5-git-send-email-geert@linux-m68k.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 6 Feb 2011 11:51:09 +0100
> + dev->trans_start = jiffies;
Device drivers no longer make this operation, the generic code
does it (see net/core/dev.c:dev_hard_start_xmit() and how it
invokes txq_trans_update() on ->ndo_start_xmit() success).
Therefore, please remove this line.
> + pr_debug(DRV_NAME ": send %d bytes\n", len);
For consistency with other network drivers, add an appropriate CPP
define for "pr_fmt" and use netdev_info(), netdev_debug(), etc.
In situations where a netdev pointer is not available
(ie. pre-register_netdev()), use "dev_*()" instead.
Thanks.
next prev parent reply other threads:[~2011-02-06 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1296989469-7844-1-git-send-email-geert@linux-m68k.org>
2011-02-06 10:51 ` [PATCH 4/4] m68k/atari: ARAnyM - Add support for network access Geert Uytterhoeven
2011-02-06 12:30 ` Petr Stehlik
2011-02-06 12:52 ` [Aranym-dev] " Milan Jurik
2011-02-06 19:17 ` David Miller [this message]
2011-02-10 8:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206.111705.183051866.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=M.Jurik@sh.cvut.cz \
--cc=cz-bobek-lists-aranym@lists.bobek.cz \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pstehlik@sophics.cz \
--cc=schmitz@opal.biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).