From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: x25: possible skb leak on bad facilities Date: Sun, 06 Feb 2011 20:28:24 -0800 (PST) Message-ID: <20110206.202824.260090071.davem@davemloft.net> References: <20110131130826.GC16804@shadowen.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: apw@canonical.com, john@calva.com, linux-x25@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tim.gardner@canonical.com To: andrew.hendry@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43515 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652Ab1BGE1s (ORCPT ); Sun, 6 Feb 2011 23:27:48 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Andrew Hendry Date: Tue, 1 Feb 2011 22:55:13 +1100 > There are two callers, when I was crashing it I don't remember it > using the backlog path. > x25_process_rx_frame is called from both x25_backlog_rcv and also > x25_receive_data (via x25_lapb_receive_frame) > > But reviewing that second path now it looks like it will also leak, -1 > would make it skip the kfree_skb there as well. > So patch looks good to me, when I have some time I'll run it through > the environment I had setup originally to confirm. Andrew, have you had a chance to do this yet?