From: David Miller <davem@davemloft.net>
To: mirq-linux@rere.qmqm.pl
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH v4 2/5] net: ethtool: use ndo_fix_features for offload setting
Date: Mon, 07 Feb 2011 13:01:24 -0800 (PST) [thread overview]
Message-ID: <20110207.130124.189688858.davem@davemloft.net> (raw)
In-Reply-To: <ca3bcc3bec8779b67b476d5d7325ea9fbbf54308.1296741561.git.mirq-linux@rere.qmqm.pl>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Thu, 3 Feb 2011 15:21:21 +0100 (CET)
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, and now I see why the tree "built" successfully for
you.
You remove the duplicate EXPORT_SYMBOL() in this patch.
You absolutely cannot test your patch sets like this, only
build testing at the end.
Every single individual change must not introduce any functional
or build regressions, therefore you must make sure the build works
fine after each and every patch in your series, not just after they
are all applied.
What disturbs me even more, is that really this problem was introduced
because you mixed functional and cleanup changes in the first patch.
Something you should also never do.
next prev parent reply other threads:[~2011-02-07 21:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 14:21 [PATCH v4 0/5] net: Unified offload configuration Michał Mirosław
2011-02-03 14:21 ` [PATCH v4 2/5] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-02-07 21:01 ` David Miller [this message]
2011-02-03 14:21 ` [PATCH v4 1/5] net: Introduce new feature setting ops Michał Mirosław
2011-02-07 19:39 ` Ben Hutchings
2011-02-07 20:51 ` David Miller
2011-02-07 20:55 ` David Miller
2012-01-24 13:54 ` Eric Dumazet
2012-01-24 15:30 ` Ben Hutchings
2012-01-24 15:47 ` Eric Dumazet
2012-01-24 19:05 ` Michał Mirosław
2012-01-28 8:30 ` [RFC PATCH] ethtool: implement [GS]FEATURES handling Michał Mirosław
2012-01-28 8:37 ` [RFC PATCH v2] " Michał Mirosław
2012-01-28 10:02 ` Eric Dumazet
2011-02-03 14:21 ` [PATCH v4 3/5] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-02-07 19:46 ` Ben Hutchings
2011-02-07 21:03 ` David Miller
2011-02-03 14:21 ` [PATCH v4 4/5] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-02-07 21:12 ` David Miller
2011-02-03 14:21 ` [PATCH v2] ethtool: implement G/SFEATURES calls Michał Mirosław
2011-02-03 14:21 ` [PATCH v4 5/5] loopback: convert to hw_features Michał Mirosław
2011-02-07 21:18 ` David Miller
2011-02-07 21:37 ` [PATCH v4 0/5] net: Unified offload configuration David Miller
2011-02-07 22:49 ` Michał Mirosław
2011-02-07 22:52 ` David Miller
2011-02-07 23:12 ` Michał Mirosław
2011-02-08 19:40 ` David Miller
2011-02-08 23:55 ` Michał Mirosław
2011-02-08 23:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207.130124.189688858.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).