From: David Miller <davem@davemloft.net>
To: mirq-linux@rere.qmqm.pl
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH v4 0/5] net: Unified offload configuration
Date: Mon, 07 Feb 2011 13:37:21 -0800 (PST) [thread overview]
Message-ID: <20110207.133721.48496023.davem@davemloft.net> (raw)
In-Reply-To: <cover.1296741561.git.mirq-linux@rere.qmqm.pl>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Thu, 3 Feb 2011 15:21:21 +0100 (CET)
> Here's a v4 of the ethtool unification patch series.
>
> What's in it?
> 1:
> the patch - implement unified ethtool setting ops
> 2..3:
> implement interoperation between old and new ethtool ops
> 4:
> include RX checksum in features and plug it into new framework
> 5:
> convert loopback device to new framework
After these changes the ethtool output is now inaccurate for
RX checksumming.
Before:
davem@maramba:~$ /usr/sbin/ethtool -k eth0
Offload parameters for eth0:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp segmentation offload: off
udp fragmentation offload: off
generic segmentation offload: on
large receive offload: off
davem@maramba:~$
After:
davem@maramba:~$ /usr/sbin/ethtool -k eth0
Offload parameters for eth0:
rx-checksumming: off
tx-checksumming: on
scatter-gather: on
tcp segmentation offload: off
udp fragmentation offload: off
generic segmentation offload: on
large receive offload: off
If the issue is that you require driver or ethtool utility changes in
order for things to keep working properly, then that is not
acceptable.
I'm reverting all of these changes, resubmit them when you have them
in a state such that no regressions will be introduced.
Thanks.
next prev parent reply other threads:[~2011-02-07 21:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 14:21 [PATCH v4 0/5] net: Unified offload configuration Michał Mirosław
2011-02-03 14:21 ` [PATCH v4 2/5] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-02-07 21:01 ` David Miller
2011-02-03 14:21 ` [PATCH v4 1/5] net: Introduce new feature setting ops Michał Mirosław
2011-02-07 19:39 ` Ben Hutchings
2011-02-07 20:51 ` David Miller
2011-02-07 20:55 ` David Miller
2012-01-24 13:54 ` Eric Dumazet
2012-01-24 15:30 ` Ben Hutchings
2012-01-24 15:47 ` Eric Dumazet
2012-01-24 19:05 ` Michał Mirosław
2012-01-28 8:30 ` [RFC PATCH] ethtool: implement [GS]FEATURES handling Michał Mirosław
2012-01-28 8:37 ` [RFC PATCH v2] " Michał Mirosław
2012-01-28 10:02 ` Eric Dumazet
2011-02-03 14:21 ` [PATCH v4 3/5] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-02-07 19:46 ` Ben Hutchings
2011-02-07 21:03 ` David Miller
2011-02-03 14:21 ` [PATCH v2] ethtool: implement G/SFEATURES calls Michał Mirosław
2011-02-03 14:21 ` [PATCH v4 4/5] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-02-07 21:12 ` David Miller
2011-02-03 14:21 ` [PATCH v4 5/5] loopback: convert to hw_features Michał Mirosław
2011-02-07 21:18 ` David Miller
2011-02-07 21:37 ` David Miller [this message]
2011-02-07 22:49 ` [PATCH v4 0/5] net: Unified offload configuration Michał Mirosław
2011-02-07 22:52 ` David Miller
2011-02-07 23:12 ` Michał Mirosław
2011-02-08 19:40 ` David Miller
2011-02-08 23:55 ` Michał Mirosław
2011-02-08 23:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207.133721.48496023.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).