From: David Miller <davem@davemloft.net>
To: toshiharu-linux@dsn.okisemi.com
Cc: netdev@vger.kernel.org, tomoya-linux@dsn.okisemi.com,
qi.wang@intel.com, yong.y.wang@intel.com,
andrew.chih.howe.khor@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rx offload is set by ethtool
Date: Tue, 08 Feb 2011 22:57:02 -0800 (PST) [thread overview]
Message-ID: <20110208.225702.104076116.davem@davemloft.net> (raw)
In-Reply-To: <3F7E1C17407A45E3834BF70553CB294C@hacdom.okisemi.com>
From: "Toshiharu Okada" <toshiharu-linux@dsn.okisemi.com>
Date: Wed, 9 Feb 2011 11:04:11 +0900
> From: David Miller <davem@davemloft.net>
> Date: Tue, 08 Feb 2011 16:40:30 -0800 (PST)
>
>>> @@ -531,12 +533,8 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter
>>> *adapter)
>>> {
>>> struct net_device *netdev = adapter->netdev;
>>>
>>> - rtnl_lock();
>>> - if (netif_running(netdev)) {
>>> - pch_gbe_down(adapter);
>>> - pch_gbe_up(adapter);
>>> - }
>>> - rtnl_unlock();
>>> + pch_gbe_down(adapter);
>>> + pch_gbe_up(adapter);
>>
>>Are you sure you can just blindly delete the netif_running() check here?
>
> Yes, sure.
> pch_gbe_reinit_locked() is called after confirming of netif_running() except
> for pch_gbe_reset_task() function.
> This netif_running() was redundant.
Thanks for explaining, applied, thank you.
next prev parent reply other threads:[~2011-02-09 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 11:33 [PATCH] pch_gbe: Fix the issue which a driver locks when rx offload is set by ethtool Toshiharu Okada
2011-02-09 0:40 ` David Miller
2011-02-09 2:04 ` Toshiharu Okada
2011-02-09 6:57 ` David Miller [this message]
2011-02-09 7:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208.225702.104076116.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.chih.howe.khor@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).