From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rx
 offload is set by ethtool
Date: Tue, 08 Feb 2011 23:04:04 -0800 (PST)
Message-ID: <20110208.230404.189683472.davem@davemloft.net>
References: <20110208.164030.242137610.davem@davemloft.net>
	<3F7E1C17407A45E3834BF70553CB294C@hacdom.okisemi.com>
	<20110208.225702.104076116.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tomoya-linux@dsn.okisemi.com,
	qi.wang@intel.com, yong.y.wang@intel.com,
	andrew.chih.howe.khor@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com, linux-kernel@vger.kernel.org
To: toshiharu-linux@dsn.okisemi.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20110208.225702.104076116.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: David Miller <davem@davemloft.net>
Date: Tue, 08 Feb 2011 22:57:02 -0800 (PST)

> From: "Toshiharu Okada" <toshiharu-linux@dsn.okisemi.com>
> Date: Wed, 9 Feb 2011 11:04:11 +0900
> 
>> From: David Miller <davem@davemloft.net>
>> Date: Tue, 08 Feb 2011 16:40:30 -0800 (PST)
>> 
>>>> @@ -531,12 +533,8 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter 
>>>> *adapter)
>>>>  {
>>>>  struct net_device *netdev = adapter->netdev;
>>>>
>>>> - rtnl_lock();
>>>> - if (netif_running(netdev)) {
>>>> - pch_gbe_down(adapter);
>>>> - pch_gbe_up(adapter);
>>>> - }
>>>> - rtnl_unlock();
>>>> + pch_gbe_down(adapter);
>>>> + pch_gbe_up(adapter);
>>>
>>>Are you sure you can just blindly delete the netif_running() check here?
>> 
>> Yes, sure.
>> pch_gbe_reinit_locked() is called after confirming of netif_running() except 
>> for pch_gbe_reset_task() function.
>> This netif_running() was redundant.
> 
> Thanks for explaining, applied, thank you.

Actually, I had to revert, this patch introduces an obvious compiler warning:

drivers/net/pch_gbe/pch_gbe_main.c: In function 'pch_gbe_reinit_locked':
drivers/net/pch_gbe/pch_gbe_main.c:533:21: warning: unused variable 'netdev'

Sloppy build issues like this reflects very poorly upon the patch
submitter.