From: David Miller <davem@davemloft.net>
To: dfeng@redhat.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
therbert@google.com, ebiederm@xmission.com,
shemminger@vyatta.com, ddvlad@rosedu.org
Subject: Re: [RFC PATCH net-next] net: rename group sysfs entry to netdev_group
Date: Wed, 09 Feb 2011 14:03:23 -0800 (PST) [thread overview]
Message-ID: <20110209.140323.39178091.davem@davemloft.net> (raw)
In-Reply-To: <1297248769-28530-1-git-send-email-dfeng@redhat.com>
From: Xiaotian feng <dfeng@redhat.com>
Date: Wed, 9 Feb 2011 18:52:49 +0800
> From: Xiaotian Feng <dfeng@redhat.com>
>
> commit a512b92 adds sysfs entry for net device group, but
> before this commit, tun also uses group sysfs, so after this
> commit checkin, kernel warns like this:
> sysfs: cannot create duplicate filename '/devices/virtual/net/vnet0/group'
>
> Since tun has used this for years, rename sysfs under tun might
> break existing userspace, so rename group sysfs entry for net device
> group is a better choice.
>
> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
I don't think we have much choice in this matter, so I have applied
this patch, thanks!
next prev parent reply other threads:[~2011-02-09 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 10:52 [RFC PATCH net-next] net: rename group sysfs entry to netdev_group Xiaotian feng
2011-02-09 22:03 ` David Miller [this message]
2011-02-09 22:05 ` David Miller
2011-02-10 2:54 ` Xiaotian Feng
2011-02-10 3:16 ` David Miller
2011-02-10 9:11 ` Vlad Dogaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209.140323.39178091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ddvlad@rosedu.org \
--cc=dfeng@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).