From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH net-next] net: rename group sysfs entry to
 netdev_group
Date: Wed, 09 Feb 2011 14:03:23 -0800 (PST)
Message-ID: <20110209.140323.39178091.davem@davemloft.net>
References: <1297248769-28530-1-git-send-email-dfeng@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
	therbert@google.com, ebiederm@xmission.com, shemminger@vyatta.com,
	ddvlad@rosedu.org
To: dfeng@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39841
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753392Ab1BIWCr (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 9 Feb 2011 17:02:47 -0500
In-Reply-To: <1297248769-28530-1-git-send-email-dfeng@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Xiaotian feng <dfeng@redhat.com>
Date: Wed,  9 Feb 2011 18:52:49 +0800

> From: Xiaotian Feng <dfeng@redhat.com>
> 
> commit a512b92 adds sysfs entry for net device group, but
> before this commit, tun also uses group sysfs, so after this
> commit checkin, kernel warns like this:
>     sysfs: cannot create duplicate filename '/devices/virtual/net/vnet0/group'
> 
> Since tun has used this for years, rename sysfs under tun might
> break existing userspace, so rename group sysfs entry for net device
> group is a better choice.
> 
> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>

I don't think we have much choice in this matter, so I have applied
this patch, thanks!