public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] virtio-net: add schedule check to napi_enable call in refill_work
       [not found] <132885.30568.qm@web110313.mail.gq1.yahoo.com>
@ 2011-02-10  1:31 ` Rusty Russell
  2011-02-10  2:44   ` Bruce Rogers
  0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2011-02-10  1:31 UTC (permalink / raw)
  To: virtualization; +Cc: Ken Stailey, netdev, Bruce Rogers

On Thu, 10 Feb 2011 06:59:25 am Ken Stailey wrote:
> Justification:
> 
> Impact: Under heavy network I/O load virtio-net driver crashes making VM guest unusable.

Hmm, this went badly wrong.  I acked this patch, and it was mailed to
netdev six months ago.

Bruce's patch used spaces instead of tabs, but that should not have caused
it to be dropped.  I've taken that and ported it forwards, will repost now.

Thanks for picking this up off the floor!
Rusty.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] virtio-net: add schedule check to napi_enable call in refill_work
  2011-02-10  1:31 ` [PATCH] virtio-net: add schedule check to napi_enable call in refill_work Rusty Russell
@ 2011-02-10  2:44   ` Bruce Rogers
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Rogers @ 2011-02-10  2:44 UTC (permalink / raw)
  To: virtualization, Rusty Russell; +Cc: netdev

 >>> On 2/9/2011 at 06:31 PM, Rusty Russell <rusty@rustcorp.com.au> wrote: 
> On Thu, 10 Feb 2011 06:59:25 am Ken Stailey wrote:
>> Justification:
>> 
>> Impact: Under heavy network I/O load virtio-net driver crashes making VM 
> guest unusable.
> 
> Hmm, this went badly wrong.  I acked this patch, and it was mailed to
> netdev six months ago.
> 
> Bruce's patch used spaces instead of tabs, but that should not have caused
> it to be dropped.  I've taken that and ported it forwards, will repost now.
> 
> Thanks for picking this up off the floor!
> Rusty.

Thanks for taking care of that!

Bruce

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-10  2:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <132885.30568.qm@web110313.mail.gq1.yahoo.com>
2011-02-10  1:31 ` [PATCH] virtio-net: add schedule check to napi_enable call in refill_work Rusty Russell
2011-02-10  2:44   ` Bruce Rogers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox