From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
Thomas Fjellstrom <thomas@fjellstrom.ca>,
Jay Cliburn <jcliburn@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
Jie Yang <jie.yang@atheros.com>
Subject: [PATCH 2/3] atl1c: Do not call device_init_wakeup() in atl1c_probe()
Date: Thu, 10 Feb 2011 17:54:04 +0100 [thread overview]
Message-ID: <201102101754.04974.rjw@sisk.pl> (raw)
In-Reply-To: <201102101751.56508.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
The atl1c driver shouldn't call device_init_wakeup() in its probe
routine with the second argument equal to 1, because for PCI devices
the wakeup capability setting is initialized as appropriate by the
PCI subsystem. Remove the potentially harmful call.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/net/atl1c/atl1c_main.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/drivers/net/atl1c/atl1c_main.c
===================================================================
--- linux-2.6.orig/drivers/net/atl1c/atl1c_main.c
+++ linux-2.6/drivers/net/atl1c/atl1c_main.c
@@ -2718,7 +2718,6 @@ static int __devinit atl1c_probe(struct
goto err_reset;
}
- device_init_wakeup(&pdev->dev, 1);
/* reset the controller to
* put the device in a known good starting state */
err = atl1c_phy_init(&adapter->hw);
next prev parent reply other threads:[~2011-02-10 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 16:51 [PATCH 0/3] Net driver fixes related to power management Rafael J. Wysocki
2011-02-10 16:53 ` [PATCH 1/3] tg3: Avoid setting power.can_wakeup for devices that cannot wake up Rafael J. Wysocki
2011-02-10 20:48 ` Matt Carlson
2011-02-10 21:08 ` Rafael J. Wysocki
2011-02-11 0:00 ` Matt Carlson
2011-02-10 16:54 ` Rafael J. Wysocki [this message]
2011-02-10 16:55 ` [PATCH 3/3] atl1: Do not use legacy PCI power management Rafael J. Wysocki
2011-02-11 19:39 ` [PATCH 0/3] Net driver fixes related to " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102101754.04974.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=jcliburn@gmail.com \
--cc=jie.yang@atheros.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=thomas@fjellstrom.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).