From: Paul Mackerras <paulus@samba.org>
To: Ian Molton <ian.molton@collabora.co.uk>
Cc: netdev@vger.kernel.org, rdunlap@xenotime.net,
isdn@linux-pingi.de, arnd@arndb.de, davem@davemloft.net,
herbert@gondor.apana.org.au, ebiederm@xmission.com
Subject: Re: [RFD][PATCH] Add JMEMCMP to Berkeley Packet Filters
Date: Sat, 12 Feb 2011 13:14:41 +1100 [thread overview]
Message-ID: <20110212021441.GA3035@sammy.paulus.ozlabs.org> (raw)
In-Reply-To: <1297340087-10963-1-git-send-email-ian.molton@collabora.co.uk>
On Thu, Feb 10, 2011 at 12:14:46PM +0000, Ian Molton wrote:
> This patch implements an extension for BPF to allow filter programs to use a
> data section, along with a MEMCMP instruction.
>
> There are a few issues noted in the patch itself, which can easily be
> addressed, and I would like to check wether sk_run_filter is ever expected to
> be called from a context that cannot sleep (I dont think it is).
The ppp driver (ppp_generic.c) calls sk_run_filter inside a region
protected by spin_lock_bh, so we can't sleep there. Having sk_run_filter
potentially sleep would make it useless for ppp.
Paul.
next prev parent reply other threads:[~2011-02-12 3:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 12:14 [RFD][PATCH] Add JMEMCMP to Berkeley Packet Filters Ian Molton
2011-02-10 12:57 ` Ian Molton
2011-02-12 2:14 ` Paul Mackerras [this message]
2011-02-12 12:47 ` Ian Molton
-- strict thread matches above, loose matches on Subject: below --
2011-02-10 12:31 Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212021441.GA3035@sammy.paulus.ozlabs.org \
--to=paulus@samba.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=ian.molton@collabora.co.uk \
--cc=isdn@linux-pingi.de \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).