From: David Miller <davem@davemloft.net>
To: mirq-linux@rere.qmqm.pl
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH v5 RESEND 2/9] ethtool: enable GSO and GRO by default
Date: Sun, 13 Feb 2011 10:50:23 -0800 (PST) [thread overview]
Message-ID: <20110213.105023.68138742.davem@davemloft.net> (raw)
In-Reply-To: <66135e57d38599c0dfce347643858558c4f026c4.1297594674.git.mirq-linux@rere.qmqm.pl>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Sun, 13 Feb 2011 12:11:45 +0100 (CET)
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
This is not appropriate.
Now, every driver that lacks SG support will spit out that warning
message in netdev_fix_features().
That's why the check is there conditionalizing NETIF_F_GSO on
NETIF_F_SG in register_netdevice().
next prev parent reply other threads:[~2011-02-13 18:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 11:11 [PATCH v5 RESEND 0/9] net: Unified offload configuration Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 1/9] ethtool: move EXPORT_SYMBOL(ethtool_op_set_tx_csum) to correct place Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 4/9] ethtool: factorize get/set_one_feature Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 2/9] ethtool: enable GSO and GRO by default Michał Mirosław
2011-02-13 18:50 ` David Miller [this message]
2011-02-15 21:46 ` Michał Mirosław
2011-02-15 22:00 ` David Miller
2011-02-16 2:42 ` Michał Mirosław
2011-02-16 2:43 ` [PATCH v6 " Michał Mirosław
2011-02-16 2:48 ` David Miller
2011-02-16 2:50 ` Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 3/9] ethtool: factorize ethtool_get_strings() and ethtool_get_sset_count() Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 6/9] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 5/9] net: Introduce new feature setting ops Michał Mirosław
2011-02-16 2:43 ` [PATCH v6 " Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 9/9] loopback: convert to hw_features Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 8/9] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-02-13 11:11 ` [PATCH v5 RESEND 7/9] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110213.105023.68138742.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).