From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch C_CAN controller Date: Sun, 13 Feb 2011 10:52:16 -0800 (PST) Message-ID: <20110213.105216.27797609.davem@davemloft.net> References: <1297419478-27667-1-git-send-email-bhupesh.sharma@st.com> <4D56C0ED.1040201@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org Return-path: In-Reply-To: <4D56C0ED.1040201-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org From: Marc Kleine-Budde Date: Sat, 12 Feb 2011 18:18:37 +0100 > On 02/11/2011 11:17 AM, Bhupesh Sharma wrote: >> Bosch C_CAN controller is a full-CAN implementation which is compliant >> to CAN protocol version 2.0 part A and B. Bosch C_CAN user manual can be >> obtained from: >> http://www.semiconductors.bosch.de/media/en/pdf/ipmodules_1/ >> c_can/users_manual_c_can.pdf >> >> This patch adds the support for this controller. >> The following are the design choices made while writing the controller >> driver: >> 1. Interface Register set IF1 has be used only in the current design. >> 2. Out of the 32 Message objects available, 16 are kept aside for RX >> purposes and the rest for TX purposes. >> 3. NAPI implementation is such that both the TX and RX paths function >> in polling mode. >> >> Signed-off-by: Bhupesh Sharma > > Good work! > > Acked-by: Marc Kleine-Budde Applied.