From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: bhupesh.sharma-qxv4g6HH51o@public.gmane.org
Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch C_CAN controller
Date: Sun, 13 Feb 2011 21:43:03 -0800 (PST) [thread overview]
Message-ID: <20110213.214303.63037890.davem@davemloft.net> (raw)
In-Reply-To: <D5ECB3C7A6F99444980976A8C6D896384DEE366783-8vAmw3ZAcdzhJTuQ9jeba9BPR1lH4CV8@public.gmane.org>
From: Bhupesh SHARMA <bhupesh.sharma-qxv4g6HH51o@public.gmane.org>
Date: Mon, 14 Feb 2011 13:30:45 +0800
> I realized the problem happens when one compiles c_can files for x86 platform.
> As I have a ARM based platform, I get the "clk_get_rate", "clk_get" and
> "clk_put" definitions correctly when I perform the build operations.
>
> Now there can be two approaches to solve this issue:
> 1. Restrict C_CAN build only for ARM based platforms by adding the
> dependency "depends on HAVE_CLK" in the Kconfig file for C_CAN.
> For e.g. see the I2C_DESIGNWARE case:
> http://lxr.linux.no/linux+v2.6.31/drivers/i2c/busses/Kconfig#L329
>
> 2. Add #if defined(CONFIG_HAVE_CLK) macros to protect this code in "c_can_platform.c"
> For e.g. see: http://lxr.linux.no/linux+v2.6.31/drivers/serial/sh-sci.c#L1085
>
> IMHO, approach 2 seems better as it will allow C_CAN to work on x86 platforms
> as well which will suit Intel TopCliff platform also.
>
> Please let me know your views on the same and I will send a v8 accordingly.
#2 is definitely better.
prev parent reply other threads:[~2011-02-14 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 10:17 [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch C_CAN controller Bhupesh Sharma
[not found] ` <1297419478-27667-1-git-send-email-bhupesh.sharma-qxv4g6HH51o@public.gmane.org>
2011-02-12 14:24 ` Wolfgang Grandegger
2011-02-12 17:18 ` Marc Kleine-Budde
[not found] ` <4D56C0ED.1040201-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-02-13 18:52 ` David Miller
2011-02-13 19:05 ` David Miller
[not found] ` <20110213.110530.98884040.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-02-14 3:54 ` Bhupesh SHARMA
2011-02-14 5:30 ` Bhupesh SHARMA
[not found] ` <D5ECB3C7A6F99444980976A8C6D896384DEE366783-8vAmw3ZAcdzhJTuQ9jeba9BPR1lH4CV8@public.gmane.org>
2011-02-14 5:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110213.214303.63037890.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=bhupesh.sharma-qxv4g6HH51o@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).