From: David Miller <davem@davemloft.net>
To: leedom@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-26 1/5] cxgb4vf: Virtual Interfaces are always up ...
Date: Mon, 14 Feb 2011 14:34:23 -0800 (PST) [thread overview]
Message-ID: <20110214.143423.71126258.davem@davemloft.net> (raw)
In-Reply-To: <201102141431.32535.leedom@chelsio.com>
From: Casey Leedom <leedom@chelsio.com>
Date: Mon, 14 Feb 2011 14:31:32 -0800
> | From: Casey Leedom <leedom@chelsio.com>
> | Date: Monday, February 14, 2011 11:13 am
> |
> | | No driver specific module parameters! Add something generic and common
> | | so other drivers can use it too.
> | |
> | | Otherwise every user has to learn a different way to control this
> | | attribute, depending upon the device type, which is rediculious.
> | |
> | | How many times do we have to tell driver authors this?
> |
> | Sorry. I wasn't aware of this rule. My bad. Is this writeen down
> | somewhere under Documentation? I'm not being snarky. I really would like
> | to know so I can read through the general ground rules and avoid making
> | more mistakes in the future.
> |
> | As for a generic mechanism, what's the preferred way of doing this? A
> | new ethtool flag? Sorry for being a doofus here, I'm happy to follow
> | whatever the accepted standard is. Thanks for your time and patience.
>
> Also, I assume then the the entire patch series is now rejected, right? And
> that I should resubmit the patch series without the unacceptable module
> parameter, right? I'm just trying to figure out what I need to do next.
You need to resubmit the whole series, because changing an earlier
patch causes the subsequent ones to have, at a minimum, offsets which
GIT apply will reject.
next prev parent reply other threads:[~2011-02-14 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 1:00 [PATCH net-26 0/5] cxgb4vf: minor bug fixes Casey Leedom
2011-02-12 1:00 ` [PATCH net-26 1/5] cxgb4vf: Virtual Interfaces are always up Casey Leedom
2011-02-12 5:19 ` David Miller
2011-02-14 19:13 ` Casey Leedom
2011-02-14 22:31 ` Casey Leedom
2011-02-14 22:34 ` David Miller [this message]
2011-02-12 1:00 ` [PATCH net-26 2/5] cxgb4vf: Check driver parameters in the right place Casey Leedom
2011-02-12 1:00 ` [PATCH net-26 3/5] cxgb4vf: Behave properly when CONFIG_DEBUG_FS isn't defined Casey Leedom
2011-02-12 1:00 ` [PATCH net-26 4/5] cxgb4vf: Quiesce Virtual Interfaces on shutdown Casey Leedom
2011-02-12 7:17 ` Anirban Chakraborty
2011-02-14 19:01 ` Casey Leedom
2011-02-12 1:00 ` [PATCH net-26 5/5] cxgb4vf: Use defined Mailbox Timeout Casey Leedom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214.143423.71126258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).