From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC !!BONUS!! PATCH 6/5] ipv4: Delete routing cache.
Date: Wed, 16 Feb 2011 10:09:35 -0800 (PST) [thread overview]
Message-ID: <20110216.100935.189677289.davem@davemloft.net> (raw)
In-Reply-To: <1297842977.3201.7.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 Feb 2011 08:56:17 +0100
> Le mardi 15 février 2011 à 18:55 -0800, David Miller a écrit :
>> From: David Miller <davem@davemloft.net>
>> Date: Wed, 09 Feb 2011 22:39:39 -0800 (PST)
>>
>> >
>> > Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>> Ok, this patch had one nasty bug:
>>
>> > + if (!err == 0)
>>
>> Yeah... right.
>>
>> I'm actively testing this version at the moment, against net-next-2.6,
>> works fine thus far.
>>
>> --------------------
>> ipv4: Delete routing cache.
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> ---
>
> Reviewed-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> I suspect we can zap DST_NOCACHE later ?
Yes, the number of cleanups we can do after this patch is actually
quite large.
next prev parent reply other threads:[~2011-02-16 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 6:39 [RFC !!BONUS!! PATCH 6/5] ipv4: Delete routing cache David Miller
2011-02-16 2:55 ` David Miller
2011-02-16 7:56 ` Eric Dumazet
2011-02-16 18:09 ` David Miller [this message]
2011-03-03 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216.100935.189677289.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).