From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com, aabdulla@nvidia.com
Subject: Re: [PATCH] drivers/net: Call netif_carrier_off at the end of the probe
Date: Thu, 17 Feb 2011 14:10:11 -0800 (PST) [thread overview]
Message-ID: <20110217.141011.59671324.davem@davemloft.net> (raw)
In-Reply-To: <1297771719-14202-1-git-send-email-ivecera@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Tue, 15 Feb 2011 13:08:39 +0100
> Without calling of netif_carrier_off at the end of the probe the operstate
> is unknown when the device is initially opened. By default the carrier is
> on so when the device is opened and netif_carrier_on is called the link
> watch event is not fired and operstate remains zero (unknown).
>
> This patch fixes this behavior in forcedeth and r8169.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Applied, thanks Ivan.
prev parent reply other threads:[~2011-02-17 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 12:08 [PATCH] drivers/net: Call netif_carrier_off at the end of the probe Ivan Vecera
2011-02-15 15:22 ` Francois Romieu
2011-02-15 15:58 ` Ben Hutchings
2011-02-15 18:01 ` Ivan Vecera
2011-02-17 8:24 ` Ivan Vecera
2011-02-17 10:19 ` Francois Romieu
2011-02-17 10:32 ` Ivan Vecera
2011-02-17 13:15 ` Francois Romieu
2011-02-17 22:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217.141011.59671324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aabdulla@nvidia.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).