* [net-next-2.6 PATCH 1/3] enic: Bug fix: Reset driver count of registered unicast addresses to zero during device reset
2011-02-17 18:53 [net-next-2.6 PATCH 0/3] enic: updates to version 2.1.1.9 Vasanthy Kolluri
@ 2011-02-17 18:53 ` Vasanthy Kolluri
2011-02-17 22:14 ` David Miller
2011-02-17 18:53 ` [net-next-2.6 PATCH 2/3] enic: Clean up: Remove a not needed #ifdef Vasanthy Kolluri
2011-02-17 18:53 ` [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device Vasanthy Kolluri
2 siblings, 1 reply; 9+ messages in thread
From: Vasanthy Kolluri @ 2011-02-17 18:53 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Vasanthy Kolluri <vkolluri@cisco.com>
During a device reset, clear the counter for the no. of unicast addresses registered.
Also, rename the routines that update unicast and multicast address lists.
Signed-off-by: Christian Benvenuti <benve@cisco.com>
Signed-off-by: Danny Guo <dannguo@cisco.com>
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: David Wang <dwang2@cisco.com>
---
drivers/net/enic/enic.h | 2 +-
drivers/net/enic/enic_main.c | 13 +++++++------
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 57fcaee..5f4eb45 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -32,7 +32,7 @@
#define DRV_NAME "enic"
#define DRV_DESCRIPTION "Cisco VIC Ethernet NIC Driver"
-#define DRV_VERSION "2.1.1.6"
+#define DRV_VERSION "2.1.1.7"
#define DRV_COPYRIGHT "Copyright 2008-2011 Cisco Systems, Inc"
#define ENIC_BARS_MAX 6
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 0c24370..a625a0e 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -874,9 +874,10 @@ static struct net_device_stats *enic_get_stats(struct net_device *netdev)
return net_stats;
}
-static void enic_reset_multicast_list(struct enic *enic)
+static void enic_reset_addr_lists(struct enic *enic)
{
enic->mc_count = 0;
+ enic->uc_count = 0;
enic->flags = 0;
}
@@ -941,7 +942,7 @@ static int enic_set_mac_address(struct net_device *netdev, void *p)
return enic_dev_add_station_addr(enic);
}
-static void enic_add_multicast_addr_list(struct enic *enic)
+static void enic_update_multicast_addr_list(struct enic *enic)
{
struct net_device *netdev = enic->netdev;
struct netdev_hw_addr *ha;
@@ -996,7 +997,7 @@ static void enic_add_multicast_addr_list(struct enic *enic)
enic->mc_count = mc_count;
}
-static void enic_add_unicast_addr_list(struct enic *enic)
+static void enic_update_unicast_addr_list(struct enic *enic)
{
struct net_device *netdev = enic->netdev;
struct netdev_hw_addr *ha;
@@ -1073,9 +1074,9 @@ static void enic_set_rx_mode(struct net_device *netdev)
}
if (!promisc) {
- enic_add_unicast_addr_list(enic);
+ enic_update_unicast_addr_list(enic);
if (!allmulti)
- enic_add_multicast_addr_list(enic);
+ enic_update_multicast_addr_list(enic);
}
}
@@ -2067,7 +2068,7 @@ static void enic_reset(struct work_struct *work)
enic_dev_hang_notify(enic);
enic_stop(enic->netdev);
enic_dev_hang_reset(enic);
- enic_reset_multicast_list(enic);
+ enic_reset_addr_lists(enic);
enic_init_vnic_resources(enic);
enic_set_rss_nic_cfg(enic);
enic_dev_set_ig_vlan_rewrite_mode(enic);
^ permalink raw reply related [flat|nested] 9+ messages in thread* [net-next-2.6 PATCH 2/3] enic: Clean up: Remove a not needed #ifdef
2011-02-17 18:53 [net-next-2.6 PATCH 0/3] enic: updates to version 2.1.1.9 Vasanthy Kolluri
2011-02-17 18:53 ` [net-next-2.6 PATCH 1/3] enic: Bug fix: Reset driver count of registered unicast addresses to zero during device reset Vasanthy Kolluri
@ 2011-02-17 18:53 ` Vasanthy Kolluri
2011-02-17 22:14 ` David Miller
2011-02-17 18:53 ` [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device Vasanthy Kolluri
2 siblings, 1 reply; 9+ messages in thread
From: Vasanthy Kolluri @ 2011-02-17 18:53 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Christian Benvenuti <benve@cisco.com>
Signed-off-by: Danny Guo <dannguo@cisco.com>
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: David Wang <dwang2@cisco.com>
---
drivers/net/enic/enic.h | 2 +-
drivers/net/enic/enic_main.c | 2 --
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 5f4eb45..2ac891b 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -32,7 +32,7 @@
#define DRV_NAME "enic"
#define DRV_DESCRIPTION "Cisco VIC Ethernet NIC Driver"
-#define DRV_VERSION "2.1.1.7"
+#define DRV_VERSION "2.1.1.8"
#define DRV_COPYRIGHT "Copyright 2008-2011 Cisco Systems, Inc"
#define ENIC_BARS_MAX 6
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index a625a0e..d1aa807 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -2223,9 +2223,7 @@ static const struct net_device_ops enic_netdev_dynamic_ops = {
.ndo_tx_timeout = enic_tx_timeout,
.ndo_set_vf_port = enic_set_vf_port,
.ndo_get_vf_port = enic_get_vf_port,
-#ifdef IFLA_VF_MAX
.ndo_set_vf_mac = enic_set_vf_mac,
-#endif
#ifdef CONFIG_NET_POLL_CONTROLLER
.ndo_poll_controller = enic_poll_controller,
#endif
^ permalink raw reply related [flat|nested] 9+ messages in thread* [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device
2011-02-17 18:53 [net-next-2.6 PATCH 0/3] enic: updates to version 2.1.1.9 Vasanthy Kolluri
2011-02-17 18:53 ` [net-next-2.6 PATCH 1/3] enic: Bug fix: Reset driver count of registered unicast addresses to zero during device reset Vasanthy Kolluri
2011-02-17 18:53 ` [net-next-2.6 PATCH 2/3] enic: Clean up: Remove a not needed #ifdef Vasanthy Kolluri
@ 2011-02-17 18:53 ` Vasanthy Kolluri
2011-02-17 22:12 ` David Miller
2 siblings, 1 reply; 9+ messages in thread
From: Vasanthy Kolluri @ 2011-02-17 18:53 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Christian Benvenuti <benve@cisco.com>
Signed-off-by: Danny Guo <dannguo@cisco.com>
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: David Wang <dwang2@cisco.com>
---
drivers/net/enic/enic.h | 6 +++---
drivers/net/enic/enic_main.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 2ac891b..aee5256 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -32,13 +32,13 @@
#define DRV_NAME "enic"
#define DRV_DESCRIPTION "Cisco VIC Ethernet NIC Driver"
-#define DRV_VERSION "2.1.1.8"
+#define DRV_VERSION "2.1.1.9"
#define DRV_COPYRIGHT "Copyright 2008-2011 Cisco Systems, Inc"
#define ENIC_BARS_MAX 6
-#define ENIC_WQ_MAX 8
-#define ENIC_RQ_MAX 8
+#define ENIC_WQ_MAX 1
+#define ENIC_RQ_MAX 1
#define ENIC_CQ_MAX (ENIC_WQ_MAX + ENIC_RQ_MAX)
#define ENIC_INTR_MAX (ENIC_CQ_MAX + 2)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index d1aa807..4f1710e 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -2080,7 +2080,7 @@ static void enic_reset(struct work_struct *work)
static int enic_set_intr_mode(struct enic *enic)
{
unsigned int n = min_t(unsigned int, enic->rq_count, ENIC_RQ_MAX);
- unsigned int m = 1;
+ unsigned int m = min_t(unsigned int, enic->wq_count, ENIC_WQ_MAX);
unsigned int i;
/* Set interrupt mode (INTx, MSI, MSI-X) depending
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device
2011-02-17 18:53 ` [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device Vasanthy Kolluri
@ 2011-02-17 22:12 ` David Miller
2011-02-17 22:45 ` Vasanthy Kolluri (vkolluri)
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2011-02-17 22:12 UTC (permalink / raw)
To: vkolluri; +Cc: netdev
From: Vasanthy Kolluri <vkolluri@cisco.com>
Date: Thu, 17 Feb 2011 10:53:22 -0800
> From: Vasanthy Kolluri <vkolluri@cisco.com>
>
>
>
> Signed-off-by: Christian Benvenuti <benve@cisco.com>
> Signed-off-by: Danny Guo <dannguo@cisco.com>
> Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
> Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
> Signed-off-by: David Wang <dwang2@cisco.com>
You can't make a very serious change like this with such a terse commit
message, you have to explain exactly why this change is being made.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device
2011-02-17 22:12 ` David Miller
@ 2011-02-17 22:45 ` Vasanthy Kolluri (vkolluri)
2011-02-17 22:48 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Vasanthy Kolluri (vkolluri) @ 2011-02-17 22:45 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi Dave,
Sorry for the short description.
We believe that our earlier patch for supporting multiple hardware
receive queues per enic device requires more internal testing. At this
point, we think that it's best to disable the use of multiple receive
queues. We believe that the current patch will provide an effective
means for the same.
Thanks
Vasanthy
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, February 17, 2011 2:13 PM
To: Vasanthy Kolluri (vkolluri)
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH 3/3] enic: Always use single transmit
and single receive hardware queues per device
From: Vasanthy Kolluri <vkolluri@cisco.com>
Date: Thu, 17 Feb 2011 10:53:22 -0800
> From: Vasanthy Kolluri <vkolluri@cisco.com>
>
>
>
> Signed-off-by: Christian Benvenuti <benve@cisco.com>
> Signed-off-by: Danny Guo <dannguo@cisco.com>
> Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
> Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
> Signed-off-by: David Wang <dwang2@cisco.com>
You can't make a very serious change like this with such a terse commit
message, you have to explain exactly why this change is being made.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [net-next-2.6 PATCH 3/3] enic: Always use single transmit and single receive hardware queues per device
2011-02-17 22:45 ` Vasanthy Kolluri (vkolluri)
@ 2011-02-17 22:48 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2011-02-17 22:48 UTC (permalink / raw)
To: vkolluri; +Cc: netdev
From: "Vasanthy Kolluri (vkolluri)" <vkolluri@cisco.com>
Date: Thu, 17 Feb 2011 14:45:56 -0800
> Sorry for the short description.
>
> We believe that our earlier patch for supporting multiple hardware
> receive queues per enic device requires more internal testing. At this
> point, we think that it's best to disable the use of multiple receive
> queues. We believe that the current patch will provide an effective
> means for the same.
Well then, resubmit your patch with an appropriate commit message.
^ permalink raw reply [flat|nested] 9+ messages in thread