From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiaosuo@gmail.com, linux@horizon.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
roland@purestorage.com, dbaluta@ixiacom.com
Subject: Re: [PATCH v2] net: provide default_advmss() methods to blackhole dst_ops
Date: Fri, 18 Feb 2011 11:39:36 -0800 (PST) [thread overview]
Message-ID: <20110218.113936.193694941.davem@davemloft.net> (raw)
In-Reply-To: <1298036672.6201.65.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 18 Feb 2011 14:44:32 +0100
> Le vendredi 18 février 2011 à 14:33 +0100, Eric Dumazet a écrit :
>
>> I had this exact idea but found we need struct net pointer to get this
>> value, not provided in parameters, so I falled back to the 256 value.
>>
>>
>
> Hmm, reading again this stuff, maybe we can just use
> ipv4_default_advmss() instead of a custom one.
>
> dst->dev should be available
>
> [PATCH] net: provide default_advmss() methods to blackhole dst_ops
>
> Commit 0dbaee3b37e118a (net: Abstract default ADVMSS behind an
> accessor.) introduced a possible crash in tcp_connect_init(), when
> dst->default_advmss() is called from dst_metric_advmss()
>
> Reported-by: George Spelvin <linux@horizon.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Yes, this is a lot better, applied.
Thanks!
next prev parent reply other threads:[~2011-02-18 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110218050321.10415.qmail@science.horizon.com>
2011-02-18 6:32 ` 2.6.38-rc5 tcp_connect oops: EIP = 0x0 Eric Dumazet
2011-02-18 9:57 ` [PATCH] net: Add default_advmss() methods to blackhole dst_ops Eric Dumazet
2011-02-18 13:16 ` Changli Gao
2011-02-18 13:24 ` Eric Dumazet
2011-02-18 13:29 ` Changli Gao
2011-02-18 13:33 ` Eric Dumazet
2011-02-18 13:43 ` Daniel Baluta
2011-02-18 13:44 ` [PATCH v2] net: provide " Eric Dumazet
2011-02-18 19:39 ` David Miller [this message]
2011-02-18 19:58 ` [PATCH] net: Add " George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218.113936.193694941.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=netdev@vger.kernel.org \
--cc=roland@purestorage.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).