From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ebiederm@xmission.com, acme@redhat.com,
torvalds@linux-foundation.org, mhocko@suse.cz, mingo@elte.hu,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, xemul@openvz.org, daniel.lezcano@free.fr
Subject: Re: [PATCH] tcp: fix inet_twsk_deschedule()
Date: Sat, 19 Feb 2011 18:59:46 -0800 (PST) [thread overview]
Message-ID: <20110219.185946.193690650.davem@davemloft.net> (raw)
In-Reply-To: <1298104556.8559.21.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 19 Feb 2011 09:35:56 +0100
> [PATCH] tcp: fix inet_twsk_deschedule()
>
> Eric W. Biederman reported a lockdep splat in inet_twsk_deschedule()
>
> This is caused by inet_twsk_purge(), run from process context,
> and commit 575f4cd5a5b6394577 (net: Use rcu lookups in inet_twsk_purge.)
> removed the BH disabling that was necessary.
>
> Add the BH disabling but fine grained, right before calling
> inet_twsk_deschedule(), instead of whole function.
>
> With help from Linus Torvalds and Eric W. Biederman
>
> Reported-by: Eric W. Biederman <ebiederm@xmission.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Daniel Lezcano <daniel.lezcano@free.fr>
> CC: Pavel Emelyanov <xemul@openvz.org>
> CC: Arnaldo Carvalho de Melo <acme@redhat.com>
> CC: stable <stable@kernel.org> (# 2.6.33+)
Applied, thanks Eric.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-20 2:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110216185234.GA11636@tiehlicka.suse.cz>
[not found] ` <20110216193700.GA6377@elte.hu>
[not found] ` <AANLkTinDxxbVjrUViCs=UaMD9Wg9PR7b0ShNud5zKE3w@mail.gmail.com>
[not found] ` <AANLkTi=xnbcs5BKj3cNE_aLtBO7W5m+2uaUacu7M8g_S@mail.gmail.com>
[not found] ` <20110217090910.GA3781@tiehlicka.suse.cz>
[not found] ` <AANLkTikPKpNHxDQAYBd3fiQsmVozLtCVDsNn=+eF_q2r@mail.gmail.com>
[not found] ` <20110217163531.GF14168@elte.hu>
[not found] ` <m1pqqqfpzh.fsf@fess.ebiederm.org>
[not found] ` <AANLkTinB=EgDGNv-v-qD-MvHVAmstfP_CyyLNhhotkZx@mail.gmail.com>
[not found] ` <m1sjvm822m.fsf@fess.ebiederm.org>
[not found] ` <AANLkTimzP0UNRXutkt1zJ+OGhmeg6ga87HFyMuZQmpMj@mail.gmail.com>
[not found] ` <20110217.203647.193696765.davem@davemloft.net>
[not found] ` <1298010320.2642.7.camel@edumazet-laptop>
[not found] ` <1298014191.2642.11.camel@edumazet-laptop>
2011-02-18 8:54 ` [PATCH 1/2] net: dont leave active on stack LIST_HEAD Eric Dumazet
2011-02-18 20:14 ` David Miller
[not found] ` <m17hcx7wca.fsf@fess.ebiederm.org>
2011-02-18 8:59 ` [PATCH 2/2] net: deinit automatic LIST_HEAD Eric Dumazet
2011-02-18 20:14 ` David Miller
[not found] ` <20110218122938.GB26779@tiehlicka.suse.cz>
[not found] ` <20110218162623.GD4862@tiehlicka.suse.cz>
[not found] ` <AANLkTimO=M5xG_mnDBSxPKwSOTrp3JhHVBa8=wHsiVHY@mail.gmail.com>
2011-02-18 18:08 ` BUG: Bad page map in process udevd (anon_vma: (null)) in 2.6.38-rc4 Eric W. Biederman
2011-02-18 18:48 ` Linus Torvalds
2011-02-18 19:01 ` Arnaldo Carvalho de Melo
2011-02-18 19:11 ` Arnaldo Carvalho de Melo
2011-02-18 20:38 ` Eric W. Biederman
2011-02-19 8:35 ` [PATCH] tcp: fix inet_twsk_deschedule() Eric Dumazet
2011-02-20 2:59 ` David Miller [this message]
2011-02-18 19:13 ` BUG: Bad page map in process udevd (anon_vma: (null)) in 2.6.38-rc4 Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219.185946.193690650.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=daniel.lezcano@free.fr \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox