public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* libmnl limitation...
@ 2011-02-20 21:41 David Miller
  2011-02-20 22:25 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2011-02-20 21:41 UTC (permalink / raw)
  To: pablo; +Cc: netdev


Unfortunately, libmnl only allows setting socket options
that are of SOL_NETLINK.

This precludes setting socket options such as SO_ATTACH_FILTER
which need to be of level SOL_SOCKET.

It seems to be a mistake to have hard-coded the socket level
instead of simply letting the user specify it :-/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: libmnl limitation...
  2011-02-20 21:41 libmnl limitation David Miller
@ 2011-02-20 22:25 ` Pablo Neira Ayuso
  2011-02-20 22:31   ` Pablo Neira Ayuso
  0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2011-02-20 22:25 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

On 20/02/11 22:41, David Miller wrote:
> 
> Unfortunately, libmnl only allows setting socket options
> that are of SOL_NETLINK.
> 
> This precludes setting socket options such as SO_ATTACH_FILTER
> which need to be of level SOL_SOCKET.
> 
> It seems to be a mistake to have hard-coded the socket level
> instead of simply letting the user specify it :-/

Indeed, I'm going to obsolete the current function and provide a new
one. Sorry.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: libmnl limitation...
  2011-02-20 22:25 ` Pablo Neira Ayuso
@ 2011-02-20 22:31   ` Pablo Neira Ayuso
  2011-02-20 22:38     ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2011-02-20 22:31 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

On 20/02/11 23:25, Pablo Neira Ayuso wrote:
> On 20/02/11 22:41, David Miller wrote:
>>
>> Unfortunately, libmnl only allows setting socket options
>> that are of SOL_NETLINK.
>>
>> This precludes setting socket options such as SO_ATTACH_FILTER
>> which need to be of level SOL_SOCKET.
>>
>> It seems to be a mistake to have hard-coded the socket level
>> instead of simply letting the user specify it :-/
> 
> Indeed, I'm going to obsolete the current function and provide a new
> one. Sorry.

Actually, we can obsolete mnl_setsockopt(...), which is silly BTW, and
we can use mnl_socket_get_fd(...) with setsockopt(...).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: libmnl limitation...
  2011-02-20 22:31   ` Pablo Neira Ayuso
@ 2011-02-20 22:38     ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-02-20 22:38 UTC (permalink / raw)
  To: pablo; +Cc: netdev

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Sun, 20 Feb 2011 23:31:42 +0100

> On 20/02/11 23:25, Pablo Neira Ayuso wrote:
>> On 20/02/11 22:41, David Miller wrote:
>>>
>>> Unfortunately, libmnl only allows setting socket options
>>> that are of SOL_NETLINK.
>>>
>>> This precludes setting socket options such as SO_ATTACH_FILTER
>>> which need to be of level SOL_SOCKET.
>>>
>>> It seems to be a mistake to have hard-coded the socket level
>>> instead of simply letting the user specify it :-/
>> 
>> Indeed, I'm going to obsolete the current function and provide a new
>> one. Sorry.
> 
> Actually, we can obsolete mnl_setsockopt(...), which is silly BTW, and
> we can use mnl_socket_get_fd(...) with setsockopt(...).

Sure.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-02-20 22:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-20 21:41 libmnl limitation David Miller
2011-02-20 22:25 ` Pablo Neira Ayuso
2011-02-20 22:31   ` Pablo Neira Ayuso
2011-02-20 22:38     ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox